Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-api-client): add the method of plugin.getApps #2900

Merged

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jul 26, 2024

Why

  • Support plugin.getApps method to be able to get the list of Apps that have the specified plug-in added.

What

  • Add a document for the new methods.
  • Add new unit tests.
  • Add type for the new method request and response.

How to test

  1. prepare installed plug-ins and add a plug-in to some apps.
  2. run below code and check logs:
import {KintoneRestAPIClient} from '@kintone/rest-api-client';

const client = new KintoneRestAPIClient();

const pluginId = (await client.plugin.getPlugins({
  offset: 0,
  limit: 1
})).plugins[0].id;

console.log(await client.plugin.getApps({
  id: pluginId,
}));

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Jul 26, 2024
@shabaraba shabaraba changed the base branch from main to feat/add-method-plugin-getPlugins July 26, 2024 05:34
@shabaraba shabaraba force-pushed the feat/add-method-plugin-getApps branch from 7cc9e75 to d900172 Compare July 26, 2024 05:52
@shabaraba shabaraba marked this pull request as ready for review July 26, 2024 06:54
@shabaraba shabaraba requested a review from tasshi-me July 26, 2024 06:55
@hisasami hisasami merged commit c6097f0 into feat/add-method-plugin-getPlugins Jul 30, 2024
17 checks passed
@hisasami hisasami deleted the feat/add-method-plugin-getApps branch July 30, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants