Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest-api-client): add app.getPlugins method #2854

Merged
merged 4 commits into from
Jul 10, 2024
Merged

feat(rest-api-client): add app.getPlugins method #2854

merged 4 commits into from
Jul 10, 2024

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jul 2, 2024 •
edited
Loading

Why

Support app.getPlugins method to be able to get the list of Plug-ins added to an App.

What

  • Add new methods, app.getPlugins
  • Add unit test
    • When I run pnpm fix, I faced the warning as below in AppClientTest:
      Arrow function has too many statements (41). Maximum allowed is 40 max-statements
      So I implemented the new unit tests separately from the existing root description method.
  • Add demo script
  • Add type for AppPlugin
  • Add and Fix doc
    • I found a minor writing error in the doc of the getActions method, so I fixed it together.　 c4d7538
  • The Lang type split into AppLang and PluginLocale because they are different.

How to test

Check test spec.

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Jul 2, 2024
@shabaraba shabaraba force-pushed the feat/add-get-app-plugins-method branch from a9c9235 to 4684de2 Compare July 2, 2024 05:40
@shabaraba shabaraba marked this pull request as ready for review July 2, 2024 06:35
@shabaraba shabaraba requested a review from tasshi-me July 2, 2024 06:38
@tasshi-me tasshi-me changed the title feat(rest-api-client): add app.getPplugins method feat(rest-api-client): add app.getPlugins method Jul 5, 2024
@shabaraba
Copy link
Member Author

@tasshi-me
Sorry but I splitted the Lang type into AppLang type and PluginLocale type after you reviewed.(d7a0449)
So please check again 🙏

@shabaraba shabaraba requested a review from tasshi-me July 5, 2024 11:42
tasshi-me
tasshi-me approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit e88b9f5 into main Jul 10, 2024
17 checks passed
@tasshi-me tasshi-me deleted the feat/add-get-app-plugins-method branch July 10, 2024 02:13
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shabaraba @tasshi-me