feat(rest-api-client): add space.addSpaceFromTemplate() method
#2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hung-cybo
requested review from
a team and
tasshi-me
and removed request for
a team
tasshi-me
requested changes
Mar 21, 2024
| @@ -19,4 +19,8 @@ export abstract class BaseClient { | |||
| guestSpaceId: this.guestSpaceId, | |||
| }); | |||
| } | |||
|
|
|||
| protected buildPath(params: { endpointName: string; preview?: boolean }) { | |||
There was a problem hiding this comment.
It's difficult to understand that the buildPath() doesn't regard guestSpaceId from its name.
Please add a doc comment or rename this function.
| @@ -33,6 +33,15 @@ export type Space = { | |||
| fixedMember: boolean; | |||
| }; | |||
|
|
|||
| export type SpaceTemplate = { | |||
There was a problem hiding this comment.
This type is not a Space template.
The space template is in the kintone and referenced by id.
There was a problem hiding this comment.
You can extract this type to params directly.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
addSpaceFromTemplatemethod to be able to add a new Space from Space Template.What
addSpaceFromTemplateHow to test
Checklist
pnpm lintandpnpm teston the root directory.