Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-api-client): add space.deleteGuests() method #2621

Merged
merged 9 commits into from
Mar 19, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

Why

  • Support deleteGuests method to be able to delete guest users from Kintone.

What

  • Add new method deleteGuests
  • Add unit test
  • Add demo script

How to test

  • Check test spec

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

Co-authored-by: trigger-github-actions-release[bot] <143469140+trigger-github-actions-release[bot]@users.noreply.github.com>
@tuanphamcybozu tuanphamcybozu requested review from a team and minh-nguyen1985 and removed request for a team March 13, 2024 09:13
@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Mar 13, 2024

### deleteGuests

Deletes a Guest user from Kintone. If you would like to remove a user from a Guest Space without deleting their account, use the Update Guest Members API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes: we need to add the link to [Update Guest Members API] after we finish that PBI.

Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	examples/rest-api-client-demo/src/space.ts
#	packages/rest-api-client/docs/space.md
#	packages/rest-api-client/src/client/SpaceClient.ts
#	packages/rest-api-client/src/client/__tests__/SpaceClient.test.ts
# Conflicts:
#	examples/rest-api-client-demo/src/space.ts
#	packages/rest-api-client/docs/space.md
#	packages/rest-api-client/src/client/SpaceClient.ts
#	packages/rest-api-client/src/client/__tests__/SpaceClient.test.ts
@hung-cybo hung-cybo merged commit ac96002 into master Mar 19, 2024
10 checks passed
@hung-cybo hung-cybo deleted the feat/add-deleteGuests-method branch March 19, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants