chore(rest-api-client): fix type error for dom #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shisama
requested review from
a team,
ueokande and
tasshi-me
and removed request for
a team
tasshi-me
added a commit
that referenced
this pull request
May 19, 2022
* chore(deps): update jest monorepo to v28 * test: fix jest.config.js From jestjs/jest#12689, jest passes `rootDir` option to babel-jest. If rootDir is project sub-directory (e.g. `src/`, `__tests__/`), babel cannot load babel.config.js in project root. * chore(rest-api-client): fix type error for dom (#1513) * test(create-plugin): fix jest.config.js * chore(rest-api-client): add type definition of Blob and BlobPart Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Masaharu TASHIRO <[email protected]> Co-authored-by: tasshi / Masaharu TASHIRO <[email protected]> Co-authored-by: Masashi Hirano <[email protected]>
tasshi-me
added a commit
that referenced
this pull request
Jul 4, 2022
* chore(deps): update jest monorepo to v28 * test: fix jest.config.js From jestjs/jest#12689, jest passes `rootDir` option to babel-jest. If rootDir is project sub-directory (e.g. `src/`, `__tests__/`), babel cannot load babel.config.js in project root. * chore(rest-api-client): fix type error for dom (#1513) * test(create-plugin): fix jest.config.js * chore(rest-api-client): add type definition of Blob and BlobPart Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Masaharu TASHIRO <[email protected]> Co-authored-by: tasshi / Masaharu TASHIRO <[email protected]> Co-authored-by: Masashi Hirano <[email protected]>
tasshi-me
added a commit
that referenced
this pull request
Oct 22, 2024
* chore(deps): update jest monorepo to v28 * test: fix jest.config.js From jestjs/jest#12689, jest passes `rootDir` option to babel-jest. If rootDir is project sub-directory (e.g. `src/`, `__tests__/`), babel cannot load babel.config.js in project root. * chore(rest-api-client): fix type error for dom (#1513) * test(create-plugin): fix jest.config.js * chore(rest-api-client): add type definition of Blob and BlobPart Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Masaharu TASHIRO <[email protected]> Co-authored-by: tasshi / Masaharu TASHIRO <[email protected]> Co-authored-by: Masashi Hirano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To fix type error.
What
Cast type as BlobPart
How to test
yarn testChecklist
yarn lintandyarn teston the root directory.