Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-plugin): show prompt to choose Spanish support #2770

Merged
merged 8 commits into from
May 22, 2024
Merged

feat(create-plugin): show prompt to choose Spanish support #2770

merged 8 commits into from
May 22, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu commented May 17, 2024 •
edited
Loading

Why

  • We have started supporting Spanish (es) on plugin-manifest-validator recently.
  • create-plugin has a prompt for language support, now it will support Spanish.

What

  • Add support Spanish in prompt
  • Update readme
  • Update manifest.json to display es field
  • Update e2e test

How to test

  • pnpm test:e2e

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and tasshi-me and removed request for a team May 17, 2024 08:41
@github-actions github-actions bot added the pkg: create-plugin @kintone/create-plugin label May 17, 2024
@aws-amplify-ap-northeast-1 AWS Amplify (ap-northeast-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2770.d1ite8zvzg8c5i.amplifyapp.com

tasshi-me
tasshi-me requested changes May 19, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added Japanese prompt messages!
Please apply it!

In addition, I found error messages for plugin description seems wrong, it can be within 200 letters but 64 letters in error messages.

hung-cybo
hung-cybo approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tasshi-me tasshi-me merged commit c98ab15 into master May 22, 2024
18 checks passed
@tasshi-me tasshi-me deleted the feat/show-prompt-to-choose-Spanish-support branch May 22, 2024 03:03
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

@hung-cybo hung-cybo hung-cybo approved these changes

Assignees
No one assigned
Labels
pkg: create-plugin @kintone/create-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuanphamcybozu @tasshi-me @hung-cybo