feat(create-plugin): show prompt to choose Spanish support (#2770)

Co-authored-by: hung-nguyen <[email protected]>
kintone · May 22, 2024 · c98ab15 · c98ab15
1 parent 70e5d03
commit c98ab15
Show file tree

Hide file tree

Showing 16 changed files with 212 additions and 84 deletions.
diff --git a/packages/create-plugin/README.md b/packages/create-plugin/README.md
@@ -37,9 +37,13 @@ Let's start!
 ? Does your plugin support Chinese? Yes
 ? Input your plugin name in Chinese [1-64chars] (Optional)
 ? Input your plugin description in Chinese [1-200chars] (Optional)
+? Does your plug-in support Spanish?
+? Input your plug-in name in Spanish [1-64chars] (Optional)
+? Input your plug-in description in Spanish [1-200chars] (Optional)
 ? Input your home page url for English (Optional)
 ? Input your home page url for Japanese (Optional)
 ? Input your home page url for Chinese (Optional)
+? Input your home page url for Spanish (Optional)
 ? Does your plugin support mobile views? Yes
 ? Do you use @kintone/plugin-uploader? Yes
 :

diff --git a/packages/create-plugin/__e2e__/e2e.test.ts b/packages/create-plugin/__e2e__/e2e.test.ts
@@ -1,11 +1,6 @@
 import assert from "assert";
 import type { QuestionInput } from "./utils/CreatePlugin";
 import type { PluginTemplate } from "./utils/verification";
-import {
-  CREATE_PLUGIN_COMMAND,
-  DEFAULT_ANSWER,
-  ANSWER_NO,
-} from "./utils/constants";
 import path from "path";
 import { generateWorkingDir } from "./utils/helper";
 import fs from "fs";
@@ -14,7 +9,6 @@ import {
   assertObjectIncludes,
   readPluginManifestJson,
 } from "./utils/verification";
-import { getBoundMessage } from "../src/messages";
 import { CreatePlugin } from "./utils/CreatePlugin";
 import {
   requiredOptions,
@@ -24,9 +18,10 @@ import {
   languageEN,
   languageJA,
   emptyOutputDir,
+  existOutputDir,
+  forbiddenCharacters,
   pluginNameContain65Chars,
   pluginDescriptionContain201Chars,
-  existOutputDir,
   createKintonePluginCommand,
   minimumTemplate,
   modernTemplate,
@@ -71,6 +66,7 @@ describe("create-plugin", function () {
     modernTemplate,
     emptyOutputDir,
     existOutputDir,
+    forbiddenCharacters,
     pluginNameContain65Chars,
     pluginDescriptionContain201Chars,
     createKintonePluginCommand,
@@ -121,70 +117,6 @@ describe("create-plugin", function () {
     }
   });
 
-  it("#JsSdkTest-11 Should throw an error when the output directory contains forbidden characters", async () => {
-    const m = getBoundMessage("en");
-    let outputDir: string;
-    const isWindows = process.platform === "win32";
-    if (isWindows) {
-      outputDir = ":";
-    } else {
-      outputDir = "/";
-    }
-
-    const questionsInput: QuestionInput[] = [
-      {
-        question: m("Q_NameEn"),
-        answer: "test11-name",
-      },
-      {
-        question: m("Q_DescriptionEn"),
-        answer: "test11-description",
-      },
-      {
-        question: m("Q_SupportJa"),
-        answer: DEFAULT_ANSWER,
-      },
-      {
-        question: m("Q_SupportZh"),
-        answer: DEFAULT_ANSWER,
-      },
-      {
-        question: m("Q_WebsiteUrlEn"),
-        answer: DEFAULT_ANSWER,
-      },
-      {
-        question: m("Q_MobileSupport"),
-        answer: ANSWER_NO,
-      },
-      {
-        question: m("Q_EnablePluginUploader"),
-        answer: ANSWER_NO,
-      },
-    ];
-
-    const createPlugin = new CreatePlugin({
-      command: CREATE_PLUGIN_COMMAND,
-      workingDir,
-      outputDir,
-      questionsInput,
-    });
-    const response = await createPlugin.executeCommand();
-
-    if (isWindows) {
-      assert.equal(response.status, 1);
-      assert.match(
-        response.stderr.trim(),
-        /Could not create a plug-in project. Error:\nEINVAL: invalid argument, mkdir '.*:'/,
-      );
-    } else {
-      assert.notEqual(response.status, 0);
-      assert.match(
-        response.stderr.trim(),
-        /Error: \/ already exists. Choose a different directory/,
-      );
-    }
-  });
-
   afterEach(() => {
     const testName = expect.getState().currentTestName;
     if (!testName || !workingDir) {

diff --git a/packages/create-plugin/__e2e__/fixtures/allOptions.ts b/packages/create-plugin/__e2e__/fixtures/allOptions.ts
@@ -43,6 +43,18 @@ export const pattern: TestPattern = {
         question: m("Q_DescriptionZh"),
         answer: "我的插件",
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: ANSWER_YES,
+      },
+      {
+        question: m("Q_NameEs"),
+        answer: "test4-nombre",
+      },
+      {
+        question: m("Q_DescriptionEs"),
+        answer: "test4-descripción",
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: "https://github.com",
@@ -55,6 +67,10 @@ export const pattern: TestPattern = {
         question: m("Q_WebsiteUrlZh"),
         answer: "https://github.cn",
       },
+      {
+        question: m("Q_WebsiteUrlEs"),
+        answer: "https://github.es",
+      },
       {
         question: m("Q_MobileSupport"),
         answer: ANSWER_YES,
@@ -72,16 +88,19 @@ export const pattern: TestPattern = {
           en: "test4-name",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test4-nombre",
         },
         description: {
           en: "test4-description",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test4-descripción",
         },
         homepage_url: {
           en: "https://github.com",
           ja: "https://github.jp",
           zh: "https://github.cn",
+          es: "https://github.es",
         },
         mobile: {
           js: ["js/mobile.js"],

diff --git a/packages/create-plugin/__e2e__/fixtures/createKintonePluginCommand.ts b/packages/create-plugin/__e2e__/fixtures/createKintonePluginCommand.ts
@@ -43,6 +43,18 @@ export const pattern: TestPattern = {
         question: m("Q_DescriptionZh"),
         answer: "我的插件",
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: ANSWER_YES,
+      },
+      {
+        question: m("Q_NameEs"),
+        answer: "test14-nombre",
+      },
+      {
+        question: m("Q_DescriptionEs"),
+        answer: "test14-descripción",
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: "https://github.com",
@@ -55,6 +67,10 @@ export const pattern: TestPattern = {
         question: m("Q_WebsiteUrlZh"),
         answer: "https://github.cn",
       },
+      {
+        question: m("Q_WebsiteUrlEs"),
+        answer: "https://github.es",
+      },
       {
         question: m("Q_MobileSupport"),
         answer: ANSWER_YES,
@@ -72,16 +88,19 @@ export const pattern: TestPattern = {
           en: "test14-name",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test14-nombre",
         },
         description: {
           en: "test14-description",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test14-descripción",
         },
         homepage_url: {
           en: "https://github.com",
           ja: "https://github.jp",
           zh: "https://github.cn",
+          es: "https://github.es",
         },
         mobile: {
           js: ["js/mobile.js"],

diff --git a/packages/create-plugin/__e2e__/fixtures/forbiddenCharacters.ts b/packages/create-plugin/__e2e__/fixtures/forbiddenCharacters.ts
@@ -41,6 +41,10 @@ export const pattern: TestPattern = {
         question: m("Q_SupportZh"),
         answer: DEFAULT_ANSWER,
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: DEFAULT_ANSWER,
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: DEFAULT_ANSWER,

diff --git a/packages/create-plugin/__e2e__/fixtures/index.ts b/packages/create-plugin/__e2e__/fixtures/index.ts
@@ -5,9 +5,10 @@ export { pattern as allOptions } from "./allOptions";
 export { pattern as languageEN } from "./languageEN";
 export { pattern as languageJA } from "./languageJA";
 export { pattern as emptyOutputDir } from "./emptyOutputDir";
+export { pattern as existOutputDir } from "./existOutputDir";
+export { pattern as forbiddenCharacters } from "./forbiddenCharacters";
 export { pattern as pluginNameContain65Chars } from "./pluginNameContain65Chars";
 export { pattern as pluginDescriptionContain201Chars } from "./pluginDescriptionContain201Chars";
-export { pattern as existOutputDir } from "./existOutputDir";
 export { pattern as createKintonePluginCommand } from "./createKintonePluginCommand";
 export { pattern as minimumTemplate } from "./minimumTemplate";
 export { pattern as modernTemplate } from "./modernTemplate";
diff --git a/packages/create-plugin/__e2e__/fixtures/languageEN.ts b/packages/create-plugin/__e2e__/fixtures/languageEN.ts
@@ -49,6 +49,18 @@ export const pattern: TestPattern = {
         question: m("Q_DescriptionZh"),
         answer: "我的插件",
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: ANSWER_YES,
+      },
+      {
+        question: m("Q_NameEs"),
+        answer: "test5-nombre",
+      },
+      {
+        question: m("Q_DescriptionEs"),
+        answer: "test5-descripción",
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: "https://github.com",
@@ -61,6 +73,10 @@ export const pattern: TestPattern = {
         question: m("Q_WebsiteUrlZh"),
         answer: "https://github.cn",
       },
+      {
+        question: m("Q_WebsiteUrlEs"),
+        answer: "https://github.es",
+      },
       {
         question: m("Q_MobileSupport"),
         answer: ANSWER_NO,
@@ -78,16 +94,19 @@ export const pattern: TestPattern = {
           en: "test5-name",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test5-nombre",
         },
         description: {
           en: "test5-description",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test5-descripción",
         },
         homepage_url: {
           en: "https://github.com",
           ja: "https://github.jp",
           zh: "https://github.cn",
+          es: "https://github.es",
         },
       },
     },

diff --git a/packages/create-plugin/__e2e__/fixtures/languageJA.ts b/packages/create-plugin/__e2e__/fixtures/languageJA.ts
@@ -49,6 +49,18 @@ export const pattern: TestPattern = {
         question: m("Q_DescriptionZh"),
         answer: "我的插件",
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: ANSWER_YES,
+      },
+      {
+        question: m("Q_NameEs"),
+        answer: "test6-nombre",
+      },
+      {
+        question: m("Q_DescriptionEs"),
+        answer: "test6-descripción",
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: "https://github.com",
@@ -61,6 +73,10 @@ export const pattern: TestPattern = {
         question: m("Q_WebsiteUrlZh"),
         answer: "https://github.cn",
       },
+      {
+        question: m("Q_WebsiteUrlEs"),
+        answer: "https://github.es",
+      },
       {
         question: m("Q_MobileSupport"),
         answer: ANSWER_NO,
@@ -78,16 +94,19 @@ export const pattern: TestPattern = {
           en: "test6-name",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test6-nombre",
         },
         description: {
           en: "test6-description",
           ja: "私のプラグイン",
           zh: "我的插件",
+          es: "test6-descripción",
         },
         homepage_url: {
           en: "https://github.com",
           ja: "https://github.jp",
           zh: "https://github.cn",
+          es: "https://github.es",
         },
       },
     },

diff --git a/packages/create-plugin/__e2e__/fixtures/minimumTemplate.ts b/packages/create-plugin/__e2e__/fixtures/minimumTemplate.ts
@@ -34,6 +34,10 @@ export const pattern: TestPattern = {
         question: m("Q_SupportZh"),
         answer: DEFAULT_ANSWER,
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: DEFAULT_ANSWER,
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: DEFAULT_ANSWER,

diff --git a/packages/create-plugin/__e2e__/fixtures/modernTemplate.ts b/packages/create-plugin/__e2e__/fixtures/modernTemplate.ts
@@ -34,6 +34,10 @@ export const pattern: TestPattern = {
         question: m("Q_SupportZh"),
         answer: DEFAULT_ANSWER,
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: DEFAULT_ANSWER,
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: DEFAULT_ANSWER,

diff --git a/packages/create-plugin/__e2e__/fixtures/pluginDescriptionContain200Chars.ts b/packages/create-plugin/__e2e__/fixtures/pluginDescriptionContain200Chars.ts
@@ -33,6 +33,10 @@ export const pattern: TestPattern = {
         question: m("Q_SupportZh"),
         answer: ANSWER_NO,
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: ANSWER_NO,
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: DEFAULT_ANSWER,

diff --git a/packages/create-plugin/__e2e__/fixtures/pluginNameContain64Chars.ts b/packages/create-plugin/__e2e__/fixtures/pluginNameContain64Chars.ts
@@ -33,6 +33,10 @@ export const pattern: TestPattern = {
         question: m("Q_SupportZh"),
         answer: ANSWER_NO,
       },
+      {
+        question: m("Q_SupportEs"),
+        answer: ANSWER_NO,
+      },
       {
         question: m("Q_WebsiteUrlEn"),
         answer: DEFAULT_ANSWER,