fix(create-plugin): exit-code should be non-zero when an error occurs (…

…#2760)

Co-authored-by: Tuan Pham <[email protected]>

packages/create-plugin/__e2e__/e2e.test.ts

@@ -171,7 +171,7 @@ describe("create-plugin", function () {
     const response = await createPlugin.executeCommand();
 
     if (isWindows) {
-      assert.equal(response.status, 0);
+      assert.equal(response.status, 1);
       assert.match(
         response.stderr.trim(),
         /Could not create a plug-in project. Error:\nEINVAL: invalid argument, mkdir '.*:'/,

packages/create-plugin/__e2e__/fixtures/forbiddenCharacters.ts

@@ -0,0 +1,63 @@
+import type { TestPattern } from "../e2e.test";
+import {
+  ANSWER_NO,
+  CREATE_PLUGIN_COMMAND,
+  DEFAULT_ANSWER,
+} from "../utils/constants";
+import { getBoundMessage } from "../../src/messages";
+
+const m = getBoundMessage("en");
+let outputDir: string;
+let expectedStderr: string;
+const isWindows = process.platform === "win32";
+if (isWindows) {
+  outputDir = ":";
+  expectedStderr = `Could not create a plug-in project. Error:\\nEINVAL: invalid argument, mkdir '.*:'`;
+} else {
+  outputDir = "/";
+  expectedStderr = `Error: ${outputDir} already exists. Choose a different directory`;
+}
+
+export const pattern: TestPattern = {
+  description:
+    "#JsSdkTest-11 Should throw an error when the output directory contains forbidden characters",
+  input: {
+    command: CREATE_PLUGIN_COMMAND,
+    outputDir: outputDir,
+    questionsInput: [
+      {
+        question: m("Q_NameEn"),
+        answer: "test11-name",
+      },
+      {
+        question: m("Q_DescriptionEn"),
+        answer: "test11-description",
+      },
+      {
+        question: m("Q_SupportJa"),
+        answer: DEFAULT_ANSWER,
+      },
+      {
+        question: m("Q_SupportZh"),
+        answer: DEFAULT_ANSWER,
+      },
+      {
+        question: m("Q_WebsiteUrlEn"),
+        answer: DEFAULT_ANSWER,
+      },
+      {
+        question: m("Q_MobileSupport"),
+        answer: ANSWER_NO,
+      },
+      {
+        question: m("Q_EnablePluginUploader"),
+        answer: ANSWER_NO,
+      },
+    ],
+  },
+  expected: {
+    failure: {
+      stderr: expectedStderr,
+    },
+  },
+};

packages/create-plugin/src/index.ts

@@ -83,9 +83,14 @@ ${m("developerSite")}
       `);
     })
     .catch((error: Error) => {
-      rimraf(outputDir, { glob: true }).then(() => {
-        printError(m("Error_cannotCreatePlugin"), error.message);
-      });
+      rimraf(outputDir, { glob: true })
+        .then(() => {
+          printError(m("Error_cannotCreatePlugin"), error.message);
+        })
+        .finally(() => {
+          // eslint-disable-next-line no-process-exit
+          process.exit(1);
+        });
     });
 };