1.40.0 Update #126
Open
1.40.0 Update #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CustomNotes type updated now, this will work with the version i'll upload for 1.40.0 |
|
Unrelated but why was the name changed? Seems entirely unnecessary |
|
it bothered me? i don't have a real answer, but it's no matter now that everything else has changed too |
Closed
|
alright, seems like everything is ready, i'm fine with merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only thing worth noting is that there are two public methods for
StretchableObstaclebutSetAllPropertieslooks like the new init.i also just removed some inconsistencies in the references, and added the new
BeatSaber.GameSettingsP.S. i would wait before cores are done before merging, SongCore for example is getting rewritten and a lot of their APIs are going to change, i've already updated one here, aaaand i've done many changes in CustomNotes so i'll have to update that part too