Fix/enterprise connection for kinde #562
Conversation
WalkthroughDocumentation updates to enterprise access and MFA pages: expanded relatedArticles metadata; revised enterprise access content to include separate sections for SAML and Entra ID with required fields, reordered bullets, added a security note, and minor text/format tweaks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying kinde-docs-preview with
|
| Latest commit: |
720cff0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b35cff28.kinde-docs-preview.pages.dev |
| Branch Preview URL: | https://fix-enterprise-connection-fo.kinde-docs-preview.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/content/docs/get-started/team-and-account/mfa-for-kinde-access.mdx (1)
47-47: Typo: “SMA code” → “SMS code”.User‑facing copy error.
Apply:
-- The MFA factors that you want your team to have available to them, e.g. one or more of these factors: email code, SMA code, Authenticator app. +- The MFA factors that you want your team to have available to them, e.g. one or more of these factors: email code, SMS code, Authenticator app.
🧹 Nitpick comments (8)
src/content/docs/get-started/team-and-account/mfa-for-kinde-access.mdx (1)
27-31: Consider bumping the updated date on publish.Front matter still shows 2024-01-15 although content was changed.
src/content/docs/get-started/team-and-account/enterprise-access-to-kinde.mdx (7)
10-10: Update description and ai_summary to reflect Entra ID support (not just SAML).Metadata still says “using SAML connections”. Include Entra ID so search and related listings don’t mislead.
Apply:
-description: Guide to setting up enterprise access to Kinde using SAML connections for team member authentication via Identity Provider. +description: Guide to setting up enterprise access to Kinde using SAML or Microsoft Entra ID (OIDC) for team member authentication via your Identity Provider. @@ -ai_summary: Guide to setting up enterprise access to Kinde using SAML connections for team member authentication via Identity Provider. +ai_summary: Guide to setting up enterprise access to Kinde using SAML or Microsoft Entra ID (OIDC) for team member authentication via your Identity Provider.Also applies to: 31-31
37-37: Wording: “email ID” → “email address”.Minor clarity/consistency.
-Email your business name and email ID to [email protected] and provide the following from your Identity Provider (IdP). +Email your business name and email address to [email protected] and provide the following from your Identity Provider (IdP).
39-47: Clarify “Home realm domains” and add a doc link if available.Briefly define it (e.g., “domains we should route to your IdP”) or link to Kinde’s “home realm discovery” docs to reduce back‑and‑forth.
Would you like me to add a one‑line definition or insert a link target?
Also applies to: 48-54
48-54: Strengthen secret‑handling guidance and formatting.Don’t encourage emailing client secrets; surface the note more prominently.
For Entra ID connections: @@ - - Client Secret^ + - Client Secret^ @@ -^Contact us to discuss the most secure way to provide this information +^ Do not send secrets via email. Contact us to arrange a secure transfer method for the Client Secret.Optionally wrap the caret note in an Aside/Note component if supported for higher visibility.
Also applies to: 55-55
57-57: Capitalization and wording: URL acronyms and phrasing.Use “ACS URL”/“reply URL” and tighten the sentence.
-Once we have these, we can set up the connection and send you an ACS url (also known as a **reply url**), for example: `https://app.kinde.com/login/saml/callback`, to complete the setup with your IdP. +Once we have this information, we’ll set up the connection and send you an ACS URL (also known as a **reply URL**), for example: `https://app.kinde.com/login/saml/callback`, to complete the setup with your IdP.Please confirm the example ACS endpoint is still current for your SAML flow.
28-28: Consider bumping the updated date on publish.Front matter shows 2024-01-15 despite substantial edits.
48-53: Optional: Capture Entra tenant identifier.Consider requesting “Tenant ID (GUID)” in addition to “Microsoft Entra domain” to avoid ambiguity with custom domains.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/content/docs/get-started/team-and-account/enterprise-access-to-kinde.mdx(2 hunks)src/content/docs/get-started/team-and-account/mfa-for-kinde-access.mdx(1 hunks)
🔇 Additional comments (2)
src/content/docs/get-started/team-and-account/mfa-for-kinde-access.mdx (1)
8-8: Validate new relatedArticles UUID
- Found page_id c2a21e18-b542-4c07-a3b3-206ed4ce9508 defined in src/content/docs/authenticate/multi-factor-auth/about-multi-factor-authentication.mdx.
- The UUID is referenced in relatedArticles from:
- src/content/docs/get-started/team-and-account/mfa-for-kinde-access.mdx
- src/content/docs/authenticate/authentication-methods/sms-deliverability.mdx
- src/content/docs/authenticate/multi-factor-auth/enable-multi-factor-authentication.mdx
- src/content/docs/authenticate/multi-factor-auth/mfa-per-org.mdx
- The target page (about-multi-factor-authentication.mdx) does not list reciprocal relatedArticles to those pages; add reciprocal entries if your convention requires them.
src/content/docs/get-started/team-and-account/enterprise-access-to-kinde.mdx (1)
8-9: relatedArticles IDs validatedBoth IDs exist and map to these files:
- src/content/docs/get-started/team-and-account/mfa-for-kinde-access.mdx — page_id: 1338a25d-7e81-4793-8c68-57fb273c5df7 (title: Add MFA for accessing Kinde)
- src/content/docs/build/domains/pointing-your-domain.mdx — page_id: f0bc688b-a817-42ab-9a20-8e09cec06f37 (title: Use your own custom domain)
Update to include Entra details for EC for Kinde access
Update to cross reference pages
Summary by CodeRabbit