Skip to content

Commit

Permalink
rtl8xxxu: Fix fall-through warnings for Clang
Browse files Browse the repository at this point in the history
In preparation to enable -Wimplicit-fallthrough for Clang, fix
multiple warnings by replacing /* fall through */ comments with
the new pseudo-keyword macro fallthrough; instead of letting the
code fall through to the next case.

Notice that Clang doesn't recognize /* fall through */ comments as
implicit fall-through markings.
  • Loading branch information
kimocoder committed Dec 3, 2021
1 parent a301b4c commit 6172cad
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions rtl8xxxu_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1157,7 +1157,7 @@ void rtl8xxxu_gen1_config_channel(struct ieee80211_hw *hw)
switch (hw->conf.chandef.width) {
case NL80211_CHAN_WIDTH_20_NOHT:
ht = false;
/* fall through */
fallthrough;
case NL80211_CHAN_WIDTH_20:
opmode |= BW_OPMODE_20MHZ;
rtl8xxxu_write8(priv, REG_BW_OPMODE, opmode);
Expand Down Expand Up @@ -1284,7 +1284,7 @@ void rtl8xxxu_gen2_config_channel(struct ieee80211_hw *hw)
switch (hw->conf.chandef.width) {
case NL80211_CHAN_WIDTH_20_NOHT:
ht = false;
/* fall through */
fallthrough;
case NL80211_CHAN_WIDTH_20:
rf_mode_bw |= WMAC_TRXPTCL_CTL_BW_20;
subchannel = 0;
Expand Down Expand Up @@ -1740,13 +1740,13 @@ static int rtl8xxxu_identify_chip(struct rtl8xxxu_priv *priv)
if (val16 & NORMAL_SIE_EP_TX_HIGH_MASK) {
priv->ep_tx_high_queue = 1;
priv->ep_tx_count++;
/* fall through */
fallthrough;
}

if (val16 & NORMAL_SIE_EP_TX_NORMAL_MASK) {
priv->ep_tx_normal_queue = 1;
priv->ep_tx_count++;
/* fall through */
fallthrough;
}

if (val16 & NORMAL_SIE_EP_TX_LOW_MASK) {
Expand All @@ -1763,11 +1763,11 @@ static int rtl8xxxu_identify_chip(struct rtl8xxxu_priv *priv)
case 3:
priv->ep_tx_low_queue = 1;
priv->ep_tx_count++;
/* fall through */
fallthrough;
case 2:
priv->ep_tx_normal_queue = 1;
priv->ep_tx_count++;
/* fall through */
fallthrough;
case 1:
priv->ep_tx_high_queue = 1;
priv->ep_tx_count++;
Expand Down

0 comments on commit 6172cad

Please sign in to comment.