Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musl libc fixes #25

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Musl libc fixes #25

merged 2 commits into from
Feb 25, 2019

Conversation

lemmi
Copy link
Contributor

@lemmi lemmi commented Feb 24, 2019

I was just packaging compsize and found it won't build for musl.

Musl is a little more picky about what includes you need, so I added the missing signal.h. Other than that I think the use of __O_LARGEFILE is unnecessary and discuraged and using #define _FILE_OFFSET_BITS 64 ist the prefered way to do things, even on glibc (see man 2 open).

I confirmed these changes to work with x86_64-musl.

_FILE_OFFSET_BITS is already set to 64
@kilobyte kilobyte merged commit a7bf822 into kilobyte:master Feb 25, 2019
@kilobyte
Copy link
Owner

signal.h is obvious, thanks.

WRT __O_LARGEFILE: it works a bit differently than _FILE_OFFSET_BITS 64: the former is a flag to open() while the latter redefines open as open64() — a different syscall. And as I already had the latter, the flag is indeed redundant.

@kilobyte
Copy link
Owner

@lemmi: would a tag make your life easier?

@lemmi
Copy link
Contributor Author

lemmi commented Feb 25, 2019

@kilobyte yes it would, thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants