fix: use unsuffixed numeric literal for tuple index #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See <rust-lang/rust#60210> for more context. This has been a future-incompatibility warning since Rust 1.27, where tuple index subexpressions with invalid suffixes (in this case, `.0usize`) was erroneously accidentally accepted. This will become a hard error in Rust 1.91 after <rust-lang/rust#145463> rejects the remaining carve-outs.
Owner
|
Thanks! I doubt anyone is using this crate but I'll gladly merge a fix and push a release if a user wants it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#60210 for more context. This has been a future-incompatibility warning since Rust 1.27, where tuple index subexpressions with invalid suffixes (in this case,
.0usize) was erroneously accidentally accepted. This will become a hard error in Rust 1.91 after rust-lang/rust#145463 rejects the remaining carve-outs.You can verify the fix by running
cargo +beta test --all. Without this PR, theconvey_derive/tests/structs.rstests currently fail to compile against 1.91 beta. With this PR, the test will successfully compile.