chore(deps): supersede dependabot #144, pinning the router at the last version the mount survives - #153
Merged
Conversation
…t version the mount survives #144's bump is a version update with no advisory behind it, and its `web` job fails: `@tanstack/react-router` 1.170.33 retypes a boundary's `error` as `unknown` (TanStack #8209), which `RouteError` declared as `Error`. Two things came out of taking it seriously. The error component was lying about what it receives. The router preserves falsy throws, so `0`, `false`, `''`, `null` and a plain object all reach the boundary; the old `{error.message}` crashed outright on `null` and rendered an empty line for the rest. `errorText()` narrows for real — no cast, no `any` — and falls back to a sentence a user can read. Nine cases in `web/src/ui/routeError.test.tsx` go through the render, not the helper: eight of them fail against the previous `(error as Error).message`. The pin is the other half, and it is NOT what dependabot proposed. Latest stable is 1.170.35 / 1.168.37, verified against the registry, and the pair cannot be split: router-plugin 1.168.37 peers `^1.170.34`. From 1.170.34 (TanStack #8308) the router classifies any href carrying a scheme as an external link and returns a bare anchor with no `onClick` — and `createRemoteHistory` sets `createHref` to an absolute standalone URL by construction (issue #16), so every left-click in the federated mount would leave kilianmc.com instead of navigating in place. `remote.guard.test.tsx` catches it: 1.170.33 green, 1.170.34 red. So both packages are pinned EXACTLY rather than with a caret, because `^1.170.33` permits the version that breaks the mount. The prohibition sits on the `createHref` assignment that causes it, the guard test points at that line, and the docstring's claim that left-clicks are unaffected is now bounded by the version it stops being true at. Reworking issue #16's absolute-href mechanism is what would unblock 1.170.35. That is not this PR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #144. Same intent, different landing place, and one real bug fixed on the way.
#144 does not merge as proposed
It is a version update with no advisory — its release notes are bug fixes and type changes — and its
webjob fails.@tanstack/react-router1.170.33 retypes a boundary'serrorasunknown(TanStack #8209) andRouteErrordeclared it asError, so the component is no longer assignable at two call sites (src/router.tsx,src/routes/__root.tsx).The error component was lying about what it receives
The same upstream change preserves falsy throws, so
0,false,'',nulland plain objects all reach the boundary. The old{error.message}crashed outright onnull/undefinedand rendered an empty line for the rest.errorText()narrows for real — no cast, noany— and falls back to a readable sentence. Nine cases inweb/src/ui/routeError.test.tsxdrive the actual render rather than the helper: eight of the nine fail against the previous(error as Error).message, withTypeError: Cannot read properties of undefined (reading 'message')on the null cases.The pin is not what Dependabot proposed
Latest stable is 1.170.35 / 1.168.37, verified against the registry — and it is not takeable. The pair cannot be split (
router-plugin@1.168.37peers^1.170.34), and from 1.170.34 (TanStack #8308) the router classifies any href carrying a scheme as an external link and returns a bare<a>with noonClick.createRemoteHistorysetscreateHrefto an absoluteclimb.kilianmc.comURL by construction (issue #16, so cmd-click and copy-link reach the real app). So from 1.170.34 every ordinary left-click in the federated mount would leave kilianmc.com rather than navigate in place.remote.guard.test.tsxcaught it — 1.170.33 green, 1.170.34 red — bisected against the registry.@tanstack/react-router^1.170.321.170.33@tanstack/router-plugin^1.168.351.168.36Both are pinned exactly, because
^1.170.33permits the version that breaks the mount — a caret plus that peer range lets a plainnpm installfloat back to latest silently. The prohibition sits on thecreateHrefassignment that causes it, the guard test points at that line, and the docstring's "left-clicks are unaffected" claim is now bounded by the version it stops being true at.Not in this PR
Reworking issue #16's absolute-href mechanism is what would unblock 1.170.35. It needs a link component that renders an absolute href for modified clicks only, and it is its own decision.
npm run check:webgreen (1536 tests),npm run check:servergreen (1221 passed, 230 DB-backed skipped locally).🤖 Generated with Claude Code