Add encoding of nil values in tables and of empty maps #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pespinho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Kieselsteini,
The current implementation does not support encoding nil as values of a table or an empty map, which are sometimes needed for complying to some protocol specifications, e.g. MessagePack-RPC.
The changes in this pull request target adding these two features to the library.
This is achieved by adding two objects to the library that represents the two MessagePack values (NIL and EMPTY_MAP).
Since they have an unique address in Lua, it is possible to identify the intent of the user of encoding these values.
What do you think of this solution?
Best regards
Pespinho