Skip to content

improve DeleteAllGrants #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kien6034 merged 2 commits into from
Apr 25, 2024
Merged

improve DeleteAllGrants #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78386da
improve DeleteAllGrants
hoanguyenkh Apr 25, 2024
754bab8
refactor
hoanguyenkh Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions x/authz/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,20 +258,24 @@ func (k Keeper) DeleteGrant(ctx context.Context, grantee, granter sdk.AccAddress

// DeleteAllGrants revokes all authorizations granted to the grantee by the granter.
func (k Keeper) DeleteAllGrants(ctx context.Context, granter sdk.AccAddress) error {
count := 0
var keysToDelete []string

err := k.IterateGranterGrants(ctx, granter, func(grantee sdk.AccAddress, msgType string) (stop bool, err error) {
count++
if err := k.DeleteGrant(ctx, grantee, granter, msgType); err != nil {
return false, err
}
keysToDelete = append(keysToDelete, string(grantStoreKey(grantee, granter, msgType)))
return false, nil
})
if err != nil {
return err
}
if count == 0 {
if len(keysToDelete) == 0 {
return errorsmod.Wrapf(authz.ErrNoAuthorizationFound, "no grants found for granter %s", granter)
}
for _, key := range keysToDelete {
_, granteeAddr, msgType := parseGrantStoreKey([]byte(key))
if err := k.DeleteGrant(ctx, granteeAddr, granter, msgType); err != nil {
return err
}
}
return k.EventService.EventManager(ctx).Emit(&authz.EventRevokeAll{
Granter: granter.String(),
})
Expand Down