Add bcmath dependency to composer.json #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmath extension is used in `Base58::decodeAddress()` function. If bcmath is not installed, all calls to `AddressValidator::isValid()`, `AddressValidator::isPayToPublicKeyHash() & `AddressValidator::isPayToScriptHash()` will return `false`. Adding bcmath as a dependency should make this problem visible before any code is run.
|
Thanks @sh41 👍 I've just released v2.0.1 that includes your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this module, it's been really useful. I recently discovered that if bcmath is not installed all legacy validation will return false without showing any errors or failures in the code.
Adding bcmath as a dependency should make this problem visible during dependency installation.