Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kieker 1973 javassist #583

Closed
wants to merge 6 commits into from
Closed

Kieker 1973 javassist #583

wants to merge 6 commits into from

Conversation

DaGeRe
Copy link
Contributor

@DaGeRe DaGeRe commented Jun 22, 2024

Pull Request

Contribution

This pull request provides the following contribution to Kieker

  • Contribution 1 Add a Javassist probe
  • Contribution 2 Update the gradle wrapper to 8.8 in main Kieker and the examples (for future reference: This was done using start=$(pwd); wrapperfiles=$(find . -name "gradlew"); for wrapper in $wrapperfiles; do folder=$(dirname $wrapper); cd $folder; pwd; ./gradlew wrapper --gradle-version 8.8; cd $start; done)

Code Quality Thresholds

  • It was necessary to raise any code quality thresholds
  • If yes, which had to be raised and why was it necessary?
    ..

shinhyungyang
shinhyungyang previously approved these changes Jul 25, 2024
Copy link
Contributor

@shinhyungyang shinhyungyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

With a new commit c5755f2, I made sure that all gradle wrappers are updated to v8.8, using your aformentioned script (thank you!).

@DaGeRe DaGeRe force-pushed the KIEKER-1973-javassist branch 2 times, most recently from 79ebcc0 to 1a34010 Compare September 1, 2024 11:12
@DaGeRe DaGeRe mentioned this pull request Sep 4, 2024
1 task
@DaGeRe
Copy link
Contributor Author

DaGeRe commented Sep 5, 2024

This has been superseded by #620 and is no longer relevant.

@DaGeRe DaGeRe closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants