"kn workflow run" freezes when pulling registry.redhat.io images #55
Conversation
|
@ricardozanini it looks like the CI is broken |
|
it also can be reproduced in the terminal:
|
|
CI is broken on this fork. We will fix once we move to kubesmarts org. |
| @@ -205,7 +205,7 @@ func pullDockerImage(cli *client.Client, ctx context.Context) (io.ReadCloser, er | |||
| // of an image. | |||
| imageNameWithoutRegistry := strings.Split(metadata.DevModeImage, "/") | |||
| imageFilters := filters.NewArgs() | |||
| imageFilters.Add("reference", fmt.Sprintf("*/%s", imageNameWithoutRegistry[len(imageNameWithoutRegistry)-1])) | |||
| imageFilters.Add("reference", fmt.Sprintf("*/*/%s", imageNameWithoutRegistry[len(imageNameWithoutRegistry)-1])) | |||
There was a problem hiding this comment.
This should be fixed upstream, too, and the client must comply with images that are in the format <namespace>/<name>:<tag> and also <remote>/<namespace>/<name>:<tag>. Does this fix consider this scenario? Please open an issue upstream and fix it there, too, so we will have a clean branch for 1.35.
|
upstream apache#2685 |
|
@ricardozanini, there is one more topic to discuss: private registry like Right now, we can run the workflow if the docker has the image; otherwise, it fails. I think, we can create an issue to fix it as a part of our epic. |
…e in the local Docker image does not cover all cases (apache#2685) (cherry picked from commit 448d767)
|
@ricardozanini @domhanak synced with the upstream commit |
|
But we won't release anything from this branch anymore. But it's a nice to have in case we need a patch release. |
ok, what is the current feature branch? |
|
We sync with upstream in main, so your fix will come to the next release. |
JIRA: https://issues.redhat.com/browse/SRVLOGIC-419
the workflow of the issue:
registry.redhat.io/openshift-serverless-1/logic-swf-devmode-rhel8:1.34.0ordocker.io/apache/incubator-kie-sonataflow-devmode:mainthe check faileddocker.io/apache/incubator-kie-sonataflow-devmode:mainplugin tries to pull the image via Docker, the image exists and the app startsregistry.redhat.io/openshift-serverless-1/logic-swf-devmode-rhel8:1.34.0plugin tries to pull the image via Docker as well but fails because of the error: registry.redhat.io is private and the plugin can't pull the image.technically speaking, upstream has the same bug, but because of
docker.io/apache/incubator-kie-sonataflow-devmode:mainis very minor.Podman isn't affected.