[JBPM-10172] Same id used for timers when using per request #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmunozfe
approved these changes
May 24, 2023
|
SonarCloud Quality Gate failed. |
fjtirado
added
backport-7.67.x
github-actions bot
pushed a commit
that referenced
this pull request
May 26, 2023
* [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 26, 2023
* [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
This was referenced May 26, 2023
fjtirado
added a commit
that referenced
this pull request
Jun 1, 2023
…2287) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]>
fjtirado
added a commit
that referenced
this pull request
Jun 2, 2023
…2286) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]>
fjtirado
added a commit
to fjtirado/jbpm
that referenced
this pull request
Jul 25, 2023
…#2285) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
gmunozfe
added a commit
to gmunozfe/jbpm
that referenced
this pull request
Jul 26, 2023
…#2285) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
fjtirado
added a commit
to fjtirado/jbpm
that referenced
this pull request
Aug 17, 2023
…#2285) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
fjtirado
added a commit
to fjtirado/jbpm
that referenced
this pull request
Sep 15, 2023
…#2285) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
fjtirado
added a commit
to fjtirado/jbpm
that referenced
this pull request
Sep 15, 2023
…#2285) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
fjtirado
added a commit
to fjtirado/jbpm
that referenced
this pull request
Nov 7, 2023
…#2285) * [JBPM-10172] Same id used for timers when using per request * [JBPM-10172] Fix test without timer name * [KOGITO-10172] Kris proposal * [JBPM-10172] Avoiding null pointer if manager is null * [JBPM-10172] Sonar warnings * [JBPM-10172] Fixing tests --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically makes timer id to behave as if singleton strategy was used both for per request and per process instance.
Thats clearly needed on per request. Singleton remains the same and the only concern might be that know the timer id is globally unique and before, when using per process instance, it was unique per process instance.
But I think that a per process instance id into a globally unique one should not cause any issue (the contrary is not true)
Changed the approach to use the max process instance timer id if the runtime strategy if not per process instance
JIRA:
link