JBPM-10199: Mark Async nodes as finished at the SVG when process inst…

[nmirasch]

…ance is aborted

jira:https://issues.redhat.com/browse/JBPM-10199

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• a pull request please add comment: Jenkins retest this

• a full downstream build please add comment: Jenkins run fdb

• a compile downstream build please add comment: Jenkins run cdb

• a full production downstream build please add comment: Jenkins execute product fdb

• an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[nmirasch]

Jenkins run fdb

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[domhanak]

@nmirasch @fjtirado could you please share a brief explanation about why we did check by type also?

[domhanak]

I see this comment // Async active nodes don't have any related completed node instance

[nmirasch]

@domhanak before this change it only checked that the async node has an type_exit log to include it as an active one. Now it checks that it's not in the finished ones (including Exited, Aborted, Skipped and Obsolete) to be included as an active node and painted properly.

[domhanak]

Thank you! I am setting up rhpam to test the fix.

[domhanak]

jenkins do fdb

[domhanak]

jenkins do fdb

[domhanak]

jenkins do fdb

[domhanak]

@nmirasch My current end result is this:

1. Start
2. Abort via REST
   

Could you please confirm this is expected? I am a bit confused as the issue states the Human Task should have Blue Borders but it doesn't.

Another thing I noticed is a strange behavior with 2 async nodes in succesion:

No blue border anywhere. Any idea why?

From my side it looks good, the aborted process is on End Node and that makes sense.

[nmirasch]

@domhanak the weird result that I wasn't able to reproduce, is that blue border color (active nodes) after aborting the instance. I tried aborting it via rest and from the BC with the same results, no blue color anywhere. The expected node colors at the diagram are:

• Border Red: active Async nodes
• Border Blue: active nodes
• Gray filling and dark border: completed.
  If you have more details about how to reproduce the issue you found would be great, Thanks in advanced!

[domhanak]

@nmirasch Okay, I will give it another go and let you know.

[domhanak]

I have confirmed with @nmirasch that this blue bordrer on End state is not related and seems to be a separate issue. After fresh install, I am unable to reproduce it again.

Apologies for the weird issues report but I was able to do reproduce it consistently and did so several times before posting here :D

Approved.

[nmirasch]

thanks @domhanak !