Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x] RHPAM-4413 narayana-spring-boot-starter to 2.6.3 #2795

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

Ginxo
Copy link
Contributor

@Ginxo Ginxo commented Jun 30, 2022

Thank you for submitting this pull request

JIRA: https://issues.redhat.com/browse/RHPAM-4413

link

referenced Pull Requests:

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jstastny-cz
Copy link

@Ginxo we keep the original Spring Boot version? The updated narayana version is compatible with 2.5.12 version of Spring Boot, which we should align with.

@mareknovotny
Copy link
Member

mareknovotny commented Jul 14, 2022

i think that was downgraded in another PR @jstastny-cz
actually i mixed kogito PR with this.
So good point, we need to dowgrade spring boot to 2.5.12 like in https://github.com/kiegroup/kogito-runtimes/pull/2325

@mareknovotny mareknovotny self-requested a review July 14, 2022 08:57
@gmunozfe
Copy link
Member

i think that was downgraded in another PR @jstastny-cz actually i mixed kogito PR with this. So good point, we need to dowgrade spring boot to 2.5.12 like in kiegroup/kogito-runtimes#2325

right, that needs a different linked PR for droolsjbpm-build-bootstrap repo

@mareknovotny
Copy link
Member

i will merge it and please downgrade springboot in another PR ;)

@mareknovotny mareknovotny merged commit 0fb567a into 7.67.x Jul 15, 2022
@mareknovotny mareknovotny deleted the RHPAM-4413_7.67.x branch March 15, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants