-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBPM-10077 Field with LocalDateTime is forcing to enter value even th… #2780
Conversation
Jenkins run fdb |
Jenkins run fdb |
Jenkins retest this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bxf12315 the change works well in process forms but in task forms the function isn't added into the code. I'd suggest moving the function declaration to kieserver-ui.js
instead of programatically adding it into the template.
...-jbpm-ui/src/main/java/org/kie/server/services/jbpm/ui/form/render/AbstractFormRenderer.java
Outdated
Show resolved
Hide resolved
jenkins retest this please |
Jenkins run fdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments regarding the js code. I verified this code fixes the reported issue.
...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js
Outdated
Show resolved
Hide resolved
...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js
Outdated
Show resolved
Hide resolved
…ough its not marked mandatory
Jenkins run fdb |
Kudos, SonarCloud Quality Gate passed! |
Jenkins run fdb |
1 similar comment
Jenkins run fdb |
@ChughShilpa @pefernan @nmirasch is all now ok, please approve or ask for changes! |
@mareknovotny we're summarizing and evaluating possible issues, we should have the feedback in following hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functionality. It looks fine.
…ough its not marked mandatory (kiegroup#2780)
…ough its not marked mandatory (kiegroup#2780)
…ough its not marked mandatory (#2780)
…ough its not marked mandatory (#2780)
…ough its not marked mandatory
Thank you for submitting this pull request
JIRA: (please edit the JIRA link if it exists)
https://issues.redhat.com/browse/JBPM-10077
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream