[DROOLS-6894] Metrics of rule execution should include …

[tkobayas]

…rules fired from bpmn process

JIRA:
https://issues.redhat.com/browse/DROOLS-6894

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• a pull request please add comment: Jenkins retest this

• a full downstream build please add comment: Jenkins run fdb

• a compile downstream build please add comment: Jenkins run cdb

• a full production downstream build please add comment: Jenkins execute product fdb

• an upstream build please add comment: Jenkins run upstream

[tkobayas]

I added PrometheusMetricsRuleTaskListener rather than reusing PrometheusMetricsDroolsListener because fields in the class are different (= constructor parameters which can be provided are different between Drools extension use case and jBPM extension use case).

[tkobayas]

SonarCloud : 39.7% Duplication

I may be able to reduce the duplication by class inheritance. But PrometheusMetricsRuleTaskListener and PrometheusMetricsDroolsListener have different use cases and different fields so I think that separation without inheritance is easier to maintain.

[tkobayas]

Linux - Pull Request & GHA Java 8 : Failed tests are common to other PR tests. So not related to this PR.

2022-04-11T06:31:02.9793012Z [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 2.073 s <<< FAILURE! - in org.kie.server.integrationtests.scenariosimulation.ScenarioSimulationIntegrationTest

[tkobayas]

@VaniHaripriya @sutaakar Please review, thanks!

[sutaakar]

@tkobayas Do you know who could check the scesim issue?

[2022-04-11T05:26:37.112Z] Unexpected HTTP response code when requesting URI 'http://localhost:43570/kie-server-services/services/rest/server/containers/input-data-string/scesim'! Error code: 400, message: <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
[2022-04-11T05:26:37.112Z] <response type="FAILURE" msg="Test scenario parsing error: Not supported: http://javax.xml.XMLConstants/property/accessExternalDTD"/>

Would be good to address it for green builds.

[tkobayas]

Do you know who could check the scesim issue?

Sent an email to bsig list :)

[yesamer]

jenkins retest this please

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

94.3% Coverage
39.7% Duplication

[tkobayas]

Linux - Pull Request is green now. Thank you, @yesamer !

[VaniHaripriya]

@tkobayas , this looks good to me. Thank you.

[tkobayas]

@mariofusco Please merge this, thanks!