Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10050] - Failed test when running with JDK 8 - FileRepositoryTest#testWatchServiceOnLatelyCreatedConfigFile #2756

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

afalhambra
Copy link
Contributor

JBPM-10050: Failed test when running with JDK 8 - FileRepositoryTest#testWatchServiceOnLatelyCreatedConfigFile

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

…st#testWatchServiceOnLatelyCreatedConfigFile
Copy link
Member

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afalhambra
Copy link
Contributor Author

Jenkins retest this mi arma

@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@afalhambra
Copy link
Contributor Author

@mareknovotny this is ready to merge - can we also backport to 7.67.x? thanks!

@mareknovotny mareknovotny merged commit 1a8b5e6 into kiegroup:main Apr 4, 2022
afalhambra added a commit to afalhambra/droolsjbpm-integration that referenced this pull request Apr 4, 2022
mareknovotny pushed a commit that referenced this pull request Apr 5, 2022
…st#testWatchServiceOnLatelyCreatedConfigFile (#2756) (#2762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants