[KOGITO-8121]-Clean up images used by Kaniko in the docker registry

[desmax74]

See:https://issues.redhat.com/browse/KOGITO-8121
Signed-off-by: desmax74 [email protected]

Description of the change:

Motivation for the change:

Checklist

• Add or Modify a unit test for your change
• Have you verified that tall the tests are passing?

[spolti]

Hi Max, one question, where exactly these images will be store?
Is it working for k8s/ocp embedded registry?

or is it just a tool for cleaning local registries?

[desmax74]

@spolti I'm starting with local registry then I'll test with remote, but I'm expecting that the only change is the credentials and url of the docker/podman registry

[desmax74]

jenkins test this

[ricardozanini]

Looks great! Just a few comments if you don't mind!

[ricardozanini]

Can we consider adding an interface for these features? Podman and Docker have a similar API, and I believe we can leverage that.

[desmax74]

Ok, we can unify using some converter methods to expose only strings or boolean where the results provides docker or podman specific entities

[ricardozanini]

Hi! I don't think we need additional packages for this implementation. I'd do:

cleaner
- cleaner.go
- podman.go
- docker.go

[spolti]

@spolti I'm starting with local registry then I'll test with remote, but I'm expecting that the only change is the credentials and url of the docker/podman registry

for local registry isn`t better just add some instructions in the readme?
I mean, for my use case, I have a few aliases to clean the registry based on image name, tags, dangling, none, etc.

[ricardozanini]

@spolti I believe local is needed once the CLI starts using it.

[desmax74]

@spolti I'll add the env to set to use local or remote registry

[spolti]

imho this method and the above one can be combined.

[desmax74]

Ok, merged into
GetImages(args types.ImageListOptions)

GetAllImages can be called using
d.GetImages(types.ImageListOptions{All: true})

GetImageFiltered can be called using

filters := filters.NewArgs()
filters.Add("dangling", "true")
images, err := d.GetImages(types.ImageListOptions{Filters: filters})