Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDM-1788: changes related to upgrade of sshd-core 2.9.2 #1374

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

mareknovotny
Copy link
Member

@mareknovotny mareknovotny commented Jan 27, 2023

Upgrading sshd-core to 2.9.2

https://issues.redhat.com/browse/RHDM-1788 and https://issues.redhat.com/browse/RHPAM-3807

** Parent and dependent PRs **:

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

BuiltinCiphers.aes192cbc,
BuiltinCiphers.aes256cbc
));

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed managed Ciphers as we discussed in our chat

// return macs;
// }
// }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed also all commented things all together ;)

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mareknovotny
Copy link
Member Author

jenkins do cdb

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well LGTM if we have green builds. Once merged I can double check nightlys and if we have issues we can react.

@mareknovotny
Copy link
Member Author

jenkins do fdb

@mareknovotny
Copy link
Member Author

jenkins do cdb

@mareknovotny
Copy link
Member Author

jenkins do fdb

1 similar comment
@mareknovotny
Copy link
Member Author

jenkins do fdb

@mareknovotny mareknovotny added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Apr 5, 2023
@mareknovotny
Copy link
Member Author

tests now in FDB fails due old Firefox ESR installed on build node

@mareknovotny
Copy link
Member Author

jenkins do fdb

@akumar074
Copy link
Member

Jenkins run fdb

@mareknovotny
Copy link
Member Author

jenkins do cdb

@mareknovotny
Copy link
Member Author

jenkins do fdb

1 similar comment
@mareknovotny
Copy link
Member Author

jenkins do fdb

@mareknovotny
Copy link
Member Author

FDB on kiegroup/droolsjbpm-build-bootstrap#2202 is green so all is ready

@mareknovotny mareknovotny merged commit 3f02d5b into kiegroup:main Apr 26, 2023
@mareknovotny mareknovotny deleted the RHDM-1788 branch April 26, 2023 17:11
github-actions bot pushed a commit that referenced this pull request Apr 26, 2023
* RHDM-1788: changes related to upgrade of sshd-core 2.7.0

* replaced EA repository with snapshosts repository

* Removed managed ciphers and keep only default ones

* Refactoring code and fix test cases

---------

Co-authored-by: Rishiraj <[email protected]>
github-actions bot pushed a commit that referenced this pull request Apr 26, 2023
* RHDM-1788: changes related to upgrade of sshd-core 2.7.0

* replaced EA repository with snapshosts repository

* Removed managed ciphers and keep only default ones

* Refactoring code and fix test cases

---------

Co-authored-by: Rishiraj <[email protected]>
mareknovotny added a commit that referenced this pull request Apr 27, 2023
* RHDM-1788: changes related to upgrade of sshd-core 2.7.0

* replaced EA repository with snapshosts repository

* Removed managed ciphers and keep only default ones

* Refactoring code and fix test cases

---------

Co-authored-by: Marek Novotný <[email protected]>
Co-authored-by: Rishiraj <[email protected]>
mareknovotny added a commit that referenced this pull request May 4, 2023
* RHDM-1788: changes related to upgrade of sshd-core 2.7.0

* replaced EA repository with snapshosts repository

* Removed managed ciphers and keep only default ones

* Refactoring code and fix test cases

---------

Co-authored-by: Marek Novotný <[email protected]>
Co-authored-by: Rishiraj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants