RHPAM-4243 CVE-2022-0235 lerna removed from appformer-js #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JDK 11 flow failing due to GWT execution memory error |
Ginxo
changed the title
Ginxo
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
JIRA: Referenced Pull Requests: Removing lerna will also remove the indirect parse-url dependency, hence fixing CVE-2022-0722 |
lampajr
approved these changes
Aug 5, 2022
This was referenced Aug 6, 2022
|
Looks good. We aren't using lerna in any form in appformer so i dont see any negative impact of removing it. |
RishiRajAnand
approved these changes
Aug 8, 2022
Ginxo
added a commit
to Ginxo/appformer
that referenced
this pull request
Aug 8, 2022
Ginxo
added a commit
to Ginxo/appformer
that referenced
this pull request
Aug 8, 2022
This was referenced Aug 8, 2022
Ginxo
added a commit
that referenced
this pull request
Aug 8, 2022
Ginxo
added a commit
that referenced
this pull request
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://issues.redhat.com/browse/RHPAM-4243
I will backport it to 7.67.x and blue as soon as wee agree on this
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream