Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHPAM-4315: EventSource yarn.lock update #1277

Merged
merged 1 commit into from
Jul 28, 2022
Merged

RHPAM-4315: EventSource yarn.lock update #1277

merged 1 commit into from
Jul 28, 2022

Conversation

akumar074
Copy link
Member

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Hi @adrielparedes @jesuino
I tried direct updates in yarn.lock but that breaks the dashbuilder. Now, I updated the webpack-cli and webpack-dev-server version which uses the fixed versions of eventsource (1.1.1 & 2.0.2) separately. While testing locally I was able to create pages without error.
Please take a look once FDB is complete.
Thanks

@mareknovotny
Copy link
Member

jenkins retest this please

@mareknovotny
Copy link
Member

jenkins do fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@jesuino
Copy link
Contributor

jesuino commented Jun 20, 2022

Hello @akumar074

Looks like the build is breaking on dashbuilder-js, but I could not find the root cause. I will fire a new build, please let me know if you see errors when build with full profile locally.

Thanks!

@jesuino
Copy link
Contributor

jesuino commented Jun 20, 2022

jenkins execute fdb

@jesuino
Copy link
Contributor

jesuino commented Jun 20, 2022

jenkins do fdb

@akumar074 akumar074 changed the base branch from main to 7.67.x June 23, 2022 09:40
@akumar074 akumar074 changed the base branch from 7.67.x to main June 23, 2022 09:40
@akumar074
Copy link
Member Author

Jenkins run fdb

2 similar comments
@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@adrielparedes
Copy link
Contributor

@akumar074 I think there must be a problem with the PR because you are updating all the packages versions, can you please check?

@akumar074
Copy link
Member Author

Okay, looks like some commits are slipped in the PR when I rebased the branch.

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074 akumar074 requested a review from cimbalek July 12, 2022 05:35
@akumar074
Copy link
Member Author

Jenkins run cdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

3 similar comments
@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074 akumar074 requested review from tomasdavidorg and removed request for cimbalek July 19, 2022 10:33
@akumar074
Copy link
Member Author

Hello @tomasdavidorg The FDB is green. Please take a look.

@tomasdavidorg
Copy link
Contributor

tomasdavidorg commented Jul 21, 2022 •
edited
Loading

@akumar074 there are conflicts with the main branch.

@akumar074
Copy link
Member Author

Jenkins run fdb

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@akumar074
Copy link
Member Author

Jenkins run cdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run cdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run cdb

@mareknovotny
Copy link
Member

fdb passed so we can merge, right? cdb is not necessary needed to be green if FDB is ;)

@akumar074
Copy link
Member Author

@jesuino @adrielparedes The QE has approved this PR, can we go ahead and merge this?

@adrielparedes adrielparedes merged commit 9a09506 into kiegroup:main Jul 28, 2022
akumar074 added a commit to akumar074/appformer that referenced this pull request Aug 5, 2022
@akumar074
RHPAM-4315: EventSource yarn.lock update (kiegroup#1277)
d0e73ad
@akumar074 akumar074 mentioned this pull request Aug 5, 2022
Merged
akumar074 added a commit to akumar074/appformer that referenced this pull request Aug 19, 2022
@akumar074
RHPAM-4315: EventSource yarn.lock update (kiegroup#1277)
39cfc80 
(cherry picked from commit d0e73ad)
mareknovotny pushed a commit that referenced this pull request Aug 25, 2022
@akumar074
RHPAM-4315: EventSource yarn.lock update (#1277) (#1294)
b4be617
mareknovotny pushed a commit that referenced this pull request Aug 26, 2022
@akumar074
RHPAM-4315: EventSource yarn.lock update (#1277) (#1298)
5918361 
(cherry picked from commit d0e73ad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasdavidorg tomasdavidorg tomasdavidorg approved these changes

@adrielparedes adrielparedes adrielparedes approved these changes

@jesuino jesuino Awaiting requested review from jesuino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akumar074 @mareknovotny @jesuino @adrielparedes @tomasdavidorg