Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the
RebuildableStructure
interface, I finally decided to drop it as the arguments differ between the various structures: Some need a base address, some need to know the padding pattern, but most of them need none of theses. So therebuild
method is now rather a naming convention. I moved thewrite
method into a new interface calledWritableStructure
, which also adds some convenience methods to quickly write a structure into a byte array.I had to learn that there is not the one and only way to write a PE file, especially for calculated fields. Whenever I did not find enough information on the internet, I checked which algorithm variant matched most of the files in my Program Files directory. Unfortunately, in case of the
sizeOfInitializedData
, the sample executable in this git repo did not comply to the majority, so I had to apply a small hack to theResourceDirectoryTest
, namely the methodfixSizeOfInitializedData
.