Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy kiali backports on tag creator GH action #413

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

ferhoyos
Copy link
Collaborator

@ferhoyos ferhoyos commented Feb 3, 2025

Describe the change

This PR copies Kiali backports from the Kiali repo into a specific branch before the creation of a release tag using the Tag Creator GH action.

Steps to test the PR

Tested on my fork: https://github.com/ferhoyos/openshift-servicemesh-plugin/actions/runs/13107785622

Issue reference

Fixes #412

@ferhoyos ferhoyos self-assigned this Feb 3, 2025
@ferhoyos ferhoyos added the test: n/a PR does not need test additions or updates label Feb 3, 2025
git push origin $(git rev-parse HEAD):refs/heads/$BRANCH
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the script hack/copy-frontend-src-to-ossmc.sh switches by default to a different branch, the push must be made to the specific branch we want.

@ferhoyos ferhoyos requested a review from aljesusg February 3, 2025 07:56
Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@ferhoyos ferhoyos merged commit 69341cf into kiali:main Feb 3, 2025
2 checks passed
@ferhoyos ferhoyos deleted the copy-kiali-tag-creator branch February 3, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: n/a PR does not need test additions or updates
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Kiali backports are not copied to OSSMC repo
2 participants