Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation Warning KIA1701 and KIA1702 for WorkloadGroups #853

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

hhovsepy
Copy link
Contributor

@hhovsepy hhovsepy changed the title Added validation Warning KIA1701 for WorkloadGroups Added validation Warning KIA1701 and KIA1702 for WorkloadGroups Jan 27, 2025
Copy link
Contributor

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good docs, just a pair of suggestions and a small change at the end of the validation page.

content/en/docs/Features/validations.md Outdated Show resolved Hide resolved
content/en/docs/Features/validations.md Outdated Show resolved Hide resolved
content/en/docs/Features/validations.md Outdated Show resolved Hide resolved
@hhovsepy hhovsepy requested a review from ferhoyos January 29, 2025 09:41
Copy link
Contributor

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhovsepy hhovsepy merged commit 5c93c90 into kiali:staging Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants