Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zustand from 4.5.2 to 5.0.2 in /frontend #39

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 10, 2024

Bumps zustand from 4.5.2 to 5.0.2.

Release notes

Sourced from zustand's releases.

v5.0.2

This fixes some issues in middleware.

What's Changed

New Contributors

Full Changelog: pmndrs/zustand@v5.0.1...v5.0.2

v5.0.1

This fixes shallow function for some edge cases.

What's Changed

New Contributors

Full Changelog: pmndrs/zustand@v5.0.0...v5.0.1

v5.0.0

🎉🎉🎉 Zustand v5 🐻🐻🐻

TL;DR

  • No new features
  • Drop many old things
  • Migration from v4 should be smooth.

Changes in v5

  • Drop default exports
  • Drop deprecated features
  • Make React 18 the minimum required version
  • Make use-sync-external-store a peer dependency (required for createWithEqualityFn and useStoreWithEqualityFn in zustand/traditional)
  • Make TypeScript 4.5 the minimum required version
  • Drop UMD/SystemJS support
  • Organize entry points in the package.json

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Build:

  • Update zustand dependency from version 4.5.2 to 5.0.2 in the frontend package.json.

Bumps [zustand](https://github.com/pmndrs/zustand) from 4.5.2 to 5.0.2.
- [Release notes](https://github.com/pmndrs/zustand/releases)
- [Commits](pmndrs/zustand@v4.5.2...v5.0.2)

---
updated-dependencies:
- dependency-name: zustand
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 10, 2024

Dependabot tried to add @drosetti as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/khulnasoft/ThreatPot/pulls/39/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the khulnasoft/ThreatPot repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 10, 2024
Copy link

sourcery-ai bot commented Dec 10, 2024

Reviewer's Guide by Sourcery

This PR updates the Zustand dependency from version 4.5.2 to 5.0.2 in the frontend. This is a major version upgrade that introduces breaking changes, primarily focused on dropping deprecated features and modernizing the package requirements.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Major version upgrade of Zustand state management library
  • Drops default exports in favor of named exports
  • Removes deprecated features
  • Updates minimum React requirement to version 18
  • Adds use-sync-external-store as a peer dependency
  • Updates minimum TypeScript requirement to 4.5
  • Removes UMD/SystemJS support
  • Fixes devtools middleware type errors
  • Fixes async migrate functionality in persist middleware
  • Improves shallow comparison for edge cases
frontend/package.json
frontend/package-lock.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Dec 10, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

deepsource-io bot commented Dec 10, 2024

Here's the code health analysis summary for commits ec088f9..2aeca89. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@gitworkflows
Copy link
Contributor

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

Copy link

CI Failure Feedback 🧐

Action: frontend-tests / Run node.js tests (20, javascript)

Failed stage: Add dependencies [❌]

Failure summary:

The action failed due to an npm dependency resolution error:

  • The package [email protected] requires @types/react@>=18.0.0.
  • The current project has @types/[email protected] installed, which does not satisfy the required version.
  • This conflict prevents npm from resolving dependencies correctly.
  • The error suggests fixing the upstream dependency conflict or using --force or --legacy-peer-deps to
    bypass the issue.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    233:  �[36;1mif [[ 'true' != 'false' ]]; then�[0m
    234:  �[36;1m  npm i -D --package-lock-only prettier�[0m
    235:  �[36;1mfi�[0m
    236:  �[36;1mif [[ 'false' != 'false' ]]; then�[0m
    237:  �[36;1m  npm i -D --package-lock-only stylelint�[0m
    238:  �[36;1mfi�[0m
    239:  shell: /usr/bin/bash -e {0}
    240:  ##[endgroup]
    241:  npm error code ERESOLVE
    242:  npm error ERESOLVE could not resolve
    243:  npm error
    244:  npm error While resolving: [email protected]
    245:  npm error Found: @types/[email protected]
    246:  npm error node_modules/@types/react
    247:  npm error   peerOptional @types/react@">=16.8" from [email protected]
    248:  npm error   node_modules/@certego/certego-ui/node_modules/zustand
    249:  npm error     zustand@"^4.0.0-rc.0" from @certego/[email protected]
    250:  npm error     node_modules/@certego/certego-ui
    251:  npm error       @certego/certego-ui@"^0.1.10" from the root project
    252:  npm error   peerOptional @types/react@"^16.9.0 || ^17.0.0" from @testing-library/[email protected]
    253:  npm error   node_modules/@testing-library/react-hooks
    254:  npm error     dev @testing-library/react-hooks@"^8.0.1" from the root project
    255:  npm error   2 more (@types/react-dom, @types/react-transition-group)
    256:  npm error
    257:  npm error Could not resolve dependency:
    258:  npm error peerOptional @types/react@">=18.0.0" from [email protected]
    259:  npm error node_modules/zustand
    260:  npm error   zustand@"^5.0.2" from the root project
    261:  npm error
    262:  npm error Conflicting peer dependency: @types/[email protected]
    263:  npm error node_modules/@types/react
    264:  npm error   peerOptional @types/react@">=18.0.0" from [email protected]
    265:  npm error   node_modules/zustand
    266:  npm error     zustand@"^5.0.2" from the root project
    267:  npm error
    268:  npm error Fix the upstream dependency conflict, or retry
    269:  npm error this command with --force or --legacy-peer-deps
    270:  npm error to accept an incorrect (and potentially broken) dependency resolution.
    271:  npm error
    272:  npm error
    273:  npm error For a full report see:
    274:  npm error /home/runner/.npm/_logs/2024-12-10T16_51_53_970Z-eresolve-report.txt
    275:  npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-12-10T16_51_53_970Z-debug-0.log
    276:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant