Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @testing-library/react from 12.1.5 to 16.1.0 in /frontend #193

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 17, 2024

Bumps @testing-library/react from 12.1.5 to 16.1.0.

Release notes

Sourced from @​testing-library/react's releases.

v16.1.0

16.1.0 (2024-12-05)

Features

v16.0.1

16.0.1 (2024-08-29)

Bug Fixes

  • Add support for exactOptionalPropertyTypes in TypeScript (#1351) (3dcd8a9)

v16.0.0

16.0.0 (2024-06-03)

Features

  • Move @testing-library/dom and @types/react-dom to peer dependencies (#1305) (a4744fa)

BREAKING CHANGES

  • @testing-library/dom was moved to a peer dependency and needs to be explicitly installed. This reduces the chance of having conflicting versions of @testing-library/dom installed that frequently caused bugs when used with @testing-library/user-event. We will also be able to allow new versions of @testing-library/dom being used without a SemVer major release of @testing-library/react by just widening the peer dependency. @types/react-dom needs to be installed if you're typechecking files using @testing-library/react.

v15.0.7

15.0.7 (2024-05-07)

Bug Fixes

  • Ensure act is not any when React.act is not declared (#1323) (c1f2957)

v15.0.6

15.0.6 (2024-05-01)

Bug Fixes

v15.0.5

... (truncated)

Commits
  • 85ac253 feat: Add support for React 19 (#1367)
  • 3dcd8a9 fix: Add support for exactOptionalPropertyTypes in TypeScript (#1351)
  • 7a28fa9 Fix React Canary and Experimental tests (#1353)
  • a4744fa feat: Move @testing-library/dom and @types/react-dom to peer dependencie...
  • c1f2957 fix: Ensure act is not any when React.act is not declared (#1323)
  • b6e59f7 fix: export new act when available (#1319)
  • f6a1677 chore: Adjust tests to workaround 18.3.0 bug (#1315)
  • d143f46 fix: Stop restricting container option based on hydrate (#1313)
  • 48282c2 fix: Ensure renderHook options extend options for render (#1308)
  • 067d0c6 fix: Don't raise TypeScript errors when hydating document (#1304)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Build:

  • Update @testing-library/react from version 12.1.5 to 16.1.0 in package.json.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 17, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 17, 2024

Dependabot tried to add @drosetti as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/khulnasoft/ThreatMatrix/pulls/193/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the khulnasoft/ThreatMatrix repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Copy link

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This PR updates the @testing-library/react dependency from version 12.1.5 to 16.1.0 in the frontend package. The update includes several major changes, including React 19 support, TypeScript improvements, and a significant change in dependency management where @testing-library/dom is now a peer dependency.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Major version upgrade of @testing-library/react with breaking changes in dependency management
  • Moves @testing-library/dom to peer dependencies requiring explicit installation
  • Moves @types/react-dom to peer dependencies for TypeScript users
  • Adds support for React 19
  • Improves TypeScript support with exactOptionalPropertyTypes
  • Updates various bug fixes and improvements for act() functionality
frontend/package.json
frontend/package-lock.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Dec 17, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

@gitworkflows
Copy link
Contributor

gitworkflows commented Dec 17, 2024

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

deepsource-io bot commented Dec 17, 2024

Here's the code health analysis summary for commits 4d62705..a2e95f7. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

codiumai-pr-agent-free bot commented Dec 17, 2024

CI Failure Feedback 🧐

(Checks updated until commit a2e95f7)

Action: backend-tests

Failed stage: Startup script launch (Fast) [❌]

Failure summary:

The action failed due to a npm dependency conflict during the frontend build:

  • @testing-library/[email protected] requires React version 18.0.0 or 19.0.0 as a peer dependency
  • However, the project is using React 17.0.2, which is incompatible
  • The build process failed during npm install due to this unresolved dependency conflict
  • The error suggests using --force or --legacy-peer-deps to bypass this issue, but this wasn't
    implemented in the build command

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    2012:  #13 9.764 Processing triggers for shared-mime-info (2.2-1) ...
    2013:  #13 ...
    2014:  #14 [uwsgi frontend-build 4/5] RUN npm install npm@latest --location=global     && npm install     && PUBLIC_URL=/static/reactapp/ npm run build
    2015:  #14 9.032 
    2016:  #14 9.032 removed 39 packages, and changed 61 packages in 6s
    2017:  #14 9.032 
    2018:  #14 9.032 24 packages are looking for funding
    2019:  #14 9.032   run `npm fund` for details
    2020:  #14 11.14 npm error code ERESOLVE
    2021:  #14 11.14 npm error ERESOLVE could not resolve
    2022:  #14 11.14 npm error
    2023:  #14 11.14 npm error While resolving: @testing-library/[email protected]
    2024:  #14 11.14 npm error Found: [email protected]
    2025:  #14 11.14 npm error node_modules/react
    2026:  #14 11.14 npm error   react@"^17.0.2" from the root project
    2027:  #14 11.14 npm error   peer react@"^17.0.2" from @certego/[email protected]
    2028:  #14 11.14 npm error   node_modules/@certego/certego-ui
    2029:  #14 11.14 npm error     @certego/certego-ui@"^0.1.13" from the root project
    2030:  #14 11.14 npm error   45 more (@emotion/react, ...)
    2031:  #14 11.14 npm error
    2032:  #14 11.14 npm error Could not resolve dependency:
    2033:  #14 11.14 npm error peer react@"^18.0.0 || ^19.0.0" from @testing-library/[email protected]
    2034:  #14 11.14 npm error node_modules/@testing-library/react
    2035:  #14 11.14 npm error   dev @testing-library/react@"^16.1.0" from the root project
    2036:  #14 11.14 npm error
    2037:  #14 11.14 npm error Conflicting peer dependency: [email protected]
    2038:  #14 11.14 npm error node_modules/react
    2039:  #14 11.14 npm error   peer react@"^18.0.0 || ^19.0.0" from @testing-library/[email protected]
    2040:  #14 11.14 npm error   node_modules/@testing-library/react
    2041:  #14 11.14 npm error     dev @testing-library/react@"^16.1.0" from the root project
    2042:  #14 11.14 npm error
    2043:  #14 11.14 npm error Fix the upstream dependency conflict, or retry
    2044:  #14 11.14 npm error this command with --force or --legacy-peer-deps
    2045:  #14 11.14 npm error to accept an incorrect (and potentially broken) dependency resolution.
    2046:  #14 11.14 npm error
    2047:  #14 11.14 npm error
    2048:  #14 11.14 npm error For a full report see:
    2049:  #14 11.14 npm error /root/.npm/_logs/2024-12-27T00_07_10_715Z-eresolve-report.txt
    2050:  #14 11.14 npm error A complete log of this run can be found in: /root/.npm/_logs/2024-12-27T00_07_10_715Z-debug-0.log
    2051:  #14 ERROR: process "/bin/sh -c npm install npm@latest --location=global     && npm install     && PUBLIC_URL=/static/reactapp/ npm run build" did not complete successfully: exit code: 1
    2052:  #13 [uwsgi backend-build  3/10] RUN apt-get update     && apt-get install -y --no-install-recommends apt-utils libsasl2-dev libssl-dev netcat-traditional     vim libldap2-dev libfuzzy-dev net-tools python3-psycopg2 git apache2-utils tshark     && apt-get clean     && rm -rf /var/lib/apt/lists/*     && pip3 install --no-cache-dir --upgrade pip
    2053:  #13 CANCELED
    2054:  ------
    2055:  > [uwsgi frontend-build 4/5] RUN npm install npm@latest --location=global     && npm install     && PUBLIC_URL=/static/reactapp/ npm run build:
    2056:  11.14 npm error     dev @testing-library/react@"^16.1.0" from the root project
    2057:  11.14 npm error
    2058:  11.14 npm error Fix the upstream dependency conflict, or retry
    2059:  11.14 npm error this command with --force or --legacy-peer-deps
    2060:  11.14 npm error to accept an incorrect (and potentially broken) dependency resolution.
    2061:  11.14 npm error
    2062:  11.14 npm error
    2063:  11.14 npm error For a full report see:
    2064:  11.14 npm error /root/.npm/_logs/2024-12-27T00_07_10_715Z-eresolve-report.txt
    2065:  11.14 npm error A complete log of this run can be found in: /root/.npm/_logs/2024-12-27T00_07_10_715Z-debug-0.log
    2066:  ------
    2067:  failed to solve: process "/bin/sh -c npm install npm@latest --location=global     && npm install     && PUBLIC_URL=/static/reactapp/ npm run build" did not complete successfully: exit code: 1
    2068:  ##[error]Process completed with exit code 17.
    2069:  ##[group]Run docker ps -a
    2070:  �[36;1mdocker ps -a�[0m
    2071:  �[36;1mdocker logs threatmatrix_uwsgi�[0m
    2072:  �[36;1mdocker logs threatmatrix_daphne�[0m
    2073:  shell: /usr/bin/bash -e {0}
    2074:  ##[endgroup]
    2075:  CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES
    2076:  Error response from daemon: No such container: threatmatrix_uwsgi
    2077:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/develop/testing-library/react-16.1.0 branch from ed68921 to 8c58772 Compare December 26, 2024 23:43
    Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 12.1.5 to 16.1.0.
    - [Release notes](https://github.com/testing-library/react-testing-library/releases)
    - [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
    - [Commits](testing-library/react-testing-library@v12.1.5...v16.1.0)
    
    ---
    updated-dependencies:
    - dependency-name: "@testing-library/react"
      dependency-type: direct:development
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/develop/testing-library/react-16.1.0 branch from 8c58772 to a2e95f7 Compare December 27, 2024 00:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant