-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
develop add #15
develop add #15
Conversation
Reviewer's Guide by SourceryThis pull request includes a bugfix, a new feature, a feature improvement, and some refactoring. The changes involve updating the version information in the File-Level Changes
Tips
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gitworkflows - I've reviewed your changes - here's some feedback:
Overall Comments:
- The version number in _about.py is being decreased from 0.0.12 to 0.0.10. Was this intentional? Usually, we increment version numbers rather than decrement them.
- The PR is marked as both a bugfix and a new feature. Could you please clarify what bug is being fixed and what new feature is being added? The current changes in the diff don't clearly indicate either.
- Please ensure you complete the checklist in the PR description, including confirming that you've read the CONTRIBUTING document and addressed any necessary documentation changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
User description
What kind of change does this PR introduce?
Description:
Checklist:
PR Type
Enhancement, Bug fix, Dependencies
Description
readyapi_utils.py
andstreamlit_ui.py
for better readability.h5py>2
to the requirements for the image super resolution example.numpy
version requirement in the separate audio example.Changes walkthrough 📝
_about.py
Downgrade library version to 0.0.10
src/fastnode/_about.py
__version__
from "0.0.12" to "0.0.10".readyapi_utils.py
Reorder imports in `readyapi_utils.py`
src/fastnode/api/readyapi_utils.py
ReadyAPI
andForm
.streamlit_ui.py
Reorder imports in `streamlit_ui.py`
src/fastnode/ui/streamlit_ui.py
jsonable_encoder
.Dockerfile
Remove redundant COPY command in Dockerfile
playground/Dockerfile
requirements.txt
Update requirements for image super resolution example
examples/image_super_resolution/requirements.txt
h5py>2
to requirements.requirements.txt
Relax numpy version requirement for separate audio example
examples/separate_audio/requirements.txt
numpy
version requirement from "==1.18.5" to ">=1.18.5".Summary by Sourcery
Revert version number in _about.py from 0.0.12 to 0.0.10 and reorder imports in readyapi_utils.py.