This repository was archived by the owner on Jan 29, 2023. It is now read-only.
Fixed warnings from cppcheck (platformio) and -Wall arduino-cli #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry to let this PR waiting too long time as I've been busy with other things recently.I'm merging it now to Thanks for the PR, and especially the I'm looking forward for receiving more of your contributions / PR, Best Regards, |
khoih-prog
added a commit
that referenced
this pull request
Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](#10)
khoih-prog
added a commit
to khoih-prog/TimerInterrupt_Generic
that referenced
this pull request
Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](khoih-prog/TimerInterrupt#10)
khoih-prog
added a commit
to khoih-prog/TimerInterrupt_Generic
that referenced
this pull request
Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](khoih-prog/TimerInterrupt#10)
khoih-prog
added a commit
to khoih-prog/TimerInterrupt_Generic
that referenced
this pull request
Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](khoih-prog/TimerInterrupt#10)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the issue #8 raised, this is now fixed. Only tested the compilation of
examples/Argument_Simple/Argument_Simple.ino. Do let me know if you have any automated tests that can be run. Also, do let me know if I have overlooked anything with this commit.