Fix - from(nil) did not generate the expected SQL
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks great to me. Thanks for you contribution! Before merging it, could you rebase this to the latest master because of the broken CI. |
ff2248
force-pushed
the
fix/from-nil-in-mysql
branch
from
b038a02
to
b9e16e5
Compare
|
I have already rebase to the latest master branch. Please check it. Thank you. |
|
Thanks. Just release v1.1.4. See the changelog for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit:
rails/rails@bdc5141#diff-79b53b2602bf702bdd8ce677e096be6a6923a54236e17237c16068a510078683R869
Activerecord has modified the behavior of
from(nil)where it no longer substitutes withDUAL, resulting in unexpected SQL generated.While this behavior change still retrieves the data from
@idscorrectly, it causes the returned result to include many rows (the quantity is equivalent to the number of records in the table), thereby causing performance issues.