Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ruby 3.0 #22

Merged
merged 7 commits into from
Aug 19, 2023
Merged

Support Ruby 3.0 #22

merged 7 commits into from
Aug 19, 2023

Commits on Aug 19, 2023

  1. adjust assert_queries method

    khiav reoy committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    44544de View commit details
    Browse the repository at this point in the history

  2. test Ruby 3.0

    khiav reoy committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    9c3271a View commit details
    Browse the repository at this point in the history

  3. Fix: ArgumentError: wrong number of arguments

    khiav reoy committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    3243807 View commit details
    Browse the repository at this point in the history

  4. Fix: unknown type name ‘my_bool’; did you mean ‘_Bool’? 

    See: brianmario/mysql2#980

Error messages:

Fetching mysql2 0.3.21
Installing mysql2 0.3.21 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

...

compiling client.c
client.c: In function ‘nogvl_read_query_result’:
client.c:439:3: error: unknown type name ‘my_bool’; did you mean ‘_Bool’?
  439 |   my_bool res = mysql_read_query_result(client);
      |   ^~~~~~~
      |   _Bool
client.c: In function ‘rb_query’:
    khiav reoy committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    82f9d57 View commit details
    Browse the repository at this point in the history

  5. Fix pg: symbol lookup error, pg_ext.so: undefined symbol: rb_tainted_… 

    …str_new2

See: https://status.heroku.com/incidents/1940

Engineers found that Ruby Private Space apps with pg gem 1.2.0 or above are affected. We would like to ask our customers to downgrade pg gem to 1.1.4 with editing the corresponding line in the Gemfile like

'pg', '~> 1.1.4'
    khiav reoy committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    c5ea1a4 View commit details
    Browse the repository at this point in the history

  6. Use pg 1.2.x to support Ruby 3.0 

    See: ged/ruby-pg#307
    khiav reoy committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    931e230 View commit details
    Browse the repository at this point in the history

  7. Fix: ‘rb_cData’ undeclared 

    See: ged/ruby-pg#496, https://gitlab.com/gitlab-org/customers-gitlab-com/-/issues/6077
    khiav reoy committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    883e51f View commit details
    Browse the repository at this point in the history