deps: bump the nuget group (4 updates) + PublicApiAnalyzers 5.x migration#623
Merged
Conversation
…tion Redo of dependabot #621 on current main. That PR was based on the pre-constraint- chain main (@2362e3b, ~7 merges stale) and its dependabot-regenerated lock files were inconsistent with the projects (NU1004 target-framework mismatch), so its CI failed on restore --locked-mode. Bumps (Directory.Packages.props + packages.lock.json regenerated via dotnet restore --force-evaluate): - Microsoft.CodeAnalysis.BannedApiAnalyzers 4.14.0 -> 5.6.0 - Microsoft.CodeAnalysis.PublicApiAnalyzers 4.14.0 -> 5.6.0 - Microsoft.Extensions.Logging.Abstractions 10.0.0 -> 10.0.10 - Microsoft.NET.Test.Sdk 18.7.0 -> 18.8.1 PublicApiAnalyzers 5.x enforces the [Experimental] diagnostic-ID prefix in the public-API baseline: the DS0001 experimental API DeltaSharpInfo.PreviewReleaseChannel must be listed as `[DS0001]static ...PreviewReleaseChannel.get -> string!` in PublicAPI.Unshipped.txt (fixes RS0016/RS0017 under the new analyzer). Validated: restore --locked-mode clean; build -warnaserror 0/0; tests green (Core 1063x2, Engine 2929, Executor 278, Storage 1301); dotnet format clean. Supersedes #621. Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of dependabot #621 on current
main— that PR was based on the pre-constraint-chain main (2362e3b, ~7 merges stale) and its dependabot-regenerated lock files were inconsistent with the projects, so CI failed onrestore --locked-mode:What this does
Applies the same 4 bumps on current
mainand regenerates all lock files consistently (dotnet restore --force-evaluate):Required code change (analyzer major bump)
PublicApiAnalyzers 5.x enforces the
[Experimental]diagnostic-ID prefix in the public-API baseline. The lone experimental APIDeltaSharpInfo.PreviewReleaseChannel(marked[Experimental(DS0001)]) must now be listed as[DS0001]static ...PreviewReleaseChannel.get -> string!inPublicAPI.Unshipped.txt— otherwise RS0016/RS0017 fail under-warnaserror. Dependabot cannot make this source change, which is the second reason its PR could never go green.Validation
dotnet restore --locked-mode— clean (fixes the NU1004)dotnet build -c Release -warnaserror— 0 warnings, 0 errorsdotnet format --verify-no-changes— cleanSupersedes #621 (recommend closing it once this lands).
Signed-off-by: Ken Haines 1144092+khaines@users.noreply.github.com