-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 활동 멤버 및 지원서 조회 정렬 로직 변경 완료 #578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
limehee
requested changes
Sep 29, 2024
src/main/java/page/clab/api/global/common/dto/PagedResponseDto.java
Outdated
Show resolved
Hide resolved
limehee
requested changes
Sep 29, 2024
src/main/java/page/clab/api/global/common/dto/PagedResponseDto.java
Outdated
Show resolved
Hide resolved
limehee
reviewed
Oct 2, 2024
|
limehee
approved these changes
Oct 2, 2024
좋은 말씀 감사합니다..! |
mingmingmon
approved these changes
Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
활동 멤버 및 지원서 조회
api에서, 페이지에서만 정렬되도록 하는 것이 아닌, 전체 데이터를 대상으로 정렬을 한 후 페이지가 나눠지도록 변경했습니다.또한, 정렬 시 리더가 최상단에 위치할 수 있도록
PagedResponseDto
에 새로운 생성자를 만들고, 그에 따른 변경점을 수정했습니다.작업 도중,
내가 지원한 활동 목록 조회
,나의 활동 목록 조회
에서도 같은 문제를 발견해 수정했습니다.해당 변경들은 프론트엔드 및 운영진분과 함께 의논하여 문제를 발견하고, 수정했습니다.
Tasks
Results