Skip to content

Commit

Permalink
chakrashim: missing return for stubbed method
Browse files Browse the repository at this point in the history
`TracingController::CurrentTimestampMicroseconds` is declared to return
an `int64_t`, but currently returns nothing.

PR-URL: nodejs#468
Reviewed-By: Jimmy Thomson <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
  • Loading branch information
kfarnung committed Feb 23, 2018
1 parent 8b20757 commit 44889c8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions deps/chakrashim/src/v8v8.cc
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ namespace tracing {

int64_t TracingController::CurrentTimestampMicroseconds() {
jsrt::Unimplemented("TracingController");
return 0;
}

void TraceConfig::AddIncludedCategory(char const*) {
Expand Down

0 comments on commit 44889c8

Please sign in to comment.