Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Prisma to create-keystone-app #3739

Merged
merged 4 commits into from
Oct 12, 2020
Merged

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Sep 22, 2020

To test this you can run the script locally with:

 node packages/create-keystone-app/bin/cli.js

@request-info
Copy link

request-info bot commented Sep 22, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2020

🦋 Changeset detected

Latest commit: 856b0ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-keystone-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timleslie timleslie changed the title [WIP] Add support for Prisma to create-keystone-app Add support for Prisma to create-keystone-app Oct 12, 2020
@JedWatson
Copy link
Member

@timleslie just picking default values (more or less) without a database created leads to a hard error. Can we improve this?

(related; I was of the impression Prisma migrate can create the database if/when it needs to, assuming the server (i.e localhost, default port and auth) is available?)

image

Any meaningful fix here is possibly/probably out of scope for this PR, but throwing an error and crashing the process from the default choice seems like a poor experience for first users. We could catch the error, point them at the docs, and offer to continue anyway saying "You'll need to create your database after this" and that would be much nicer.

@JedWatson
Copy link
Member

Related to that last comment, when I skip the "test database" step, and follow the instructions it errors out without helping me know what next step to take to resolve the problem (spoiler: follow the docs to create a database)

I think we should do better here; we can suggest a command that will probably do what they want; or at minimum point at the guide.

If I was trying Keystone out for the first time here with less knowledge, the current experience would just be a roadblock I'd walk away from.

image

@timleslie
Copy link
Contributor Author

@timleslie just picking default values (more or less) without a database created leads to a hard error. Can we improve this?

I think in this case we should remove the default database string. At the moment there is no valid default database string which will work. We should structure the instructions such that they know that they need this value right up front.

@timleslie timleslie merged commit 002bd5b into master Oct 12, 2020
@timleslie timleslie deleted the create-prisma-app branch October 12, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants