Remove itemIds from FieldAccessArgs (#4936)

keystonejs · Feb 25, 2021 · 6469362 · 6469362 · vercel · Feb 25, 2021
1 parent 884129f
commit 6469362
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/.changeset/selfish-singers-swim.md b/.changeset/selfish-singers-swim.md
@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': major
+---
+
+Removed `itemIds` from `FieldAccessArgs` and no longer pass this value into field level imperative access control rules.
diff --git a/packages-next/keystone/src/lib/createAccessControlContext.ts b/packages-next/keystone/src/lib/createAccessControlContext.ts
@@ -18,7 +18,6 @@ type FieldAccessArgs = {
   originalInput: any;
   gqlName: string;
   itemId: any;
-  itemIds: any;
   context: KeystoneContext;
   item: any;
   fieldKey: string;
@@ -124,12 +123,7 @@ export const accessControlContext = {
     originalInput: FieldAccessArgs['originalInput'],
     item: FieldAccessArgs['item'],
     operation: FieldAccessArgs['operation'],
-    {
-      gqlName,
-      itemId,
-      itemIds,
-      context,
-    }: Pick<FieldAccessArgs, 'gqlName' | 'itemId' | 'itemIds' | 'context'>
+    { gqlName, itemId, context }: Pick<FieldAccessArgs, 'gqlName' | 'itemId' | 'context'>
   ) {
     return validateFieldAccessControl({
       access: access[context.schemaName],
@@ -141,7 +135,6 @@ export const accessControlContext = {
       listKey,
       gqlName,
       itemId,
-      itemIds,
       context,
     });
   },