Add isVerbose flag to createExpressServer (#5017)

keystonejs · Mar 5, 2021 · 0cd5acb · 0cd5acb · vercel · Mar 5, 2021
1 parent e22e7ab
commit 0cd5acb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/.changeset/lazy-snails-float.md b/.changeset/lazy-snails-float.md
@@ -0,0 +1,6 @@
+---
+'@keystone-next/keystone': minor
+'@keystone-next/test-utils-legacy': patch
+---
+
+Added an `isVerbose` flag to `createExpressServer` to allow it to be run silently during tests.
diff --git a/packages-next/keystone/src/lib/createExpressServer.ts b/packages-next/keystone/src/lib/createExpressServer.ts
@@ -61,7 +61,8 @@ export const createExpressServer = async (
   graphQLSchema: GraphQLSchema,
   createContext: CreateContext,
   dev: boolean,
-  projectAdminPath: string
+  projectAdminPath: string,
+  isVerbose: boolean = true
 ) => {
   const server = express();
 
@@ -77,13 +78,13 @@ export const createExpressServer = async (
 
   const sessionStrategy = config.session ? config.session() : undefined;
 
-  console.log('✨ Preparing GraphQL Server');
+  if (isVerbose) console.log('✨ Preparing GraphQL Server');
   addApolloServer({ server, graphQLSchema, createContext, sessionStrategy });
 
   if (config.ui?.isDisabled) {
-    console.log('✨ Skipping Admin UI app');
+    if (isVerbose) console.log('✨ Skipping Admin UI app');
   } else {
-    console.log('✨ Preparing Admin UI Next.js app');
+    if (isVerbose) console.log('✨ Preparing Admin UI Next.js app');
     server.use(
       await createAdminUIServer(config.ui, createContext, dev, projectAdminPath, sessionStrategy)
     );

diff --git a/packages/test-utils/src/index.ts b/packages/test-utils/src/index.ts
@@ -75,7 +75,7 @@ async function setupFromConfig({
     ''
   );
 
-  const app = await createExpressServer(config, graphQLSchema, createContext, true, '');
+  const app = await createExpressServer(config, graphQLSchema, createContext, true, '', false);
 
   return { keystone, context: createContext().sudo(), app };
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -75,7 +75,7 @@ async function setupFromConfig({ @@
         ''
       );
-      const app = await createExpressServer(config, graphQLSchema, createContext, true, '');
+      const app = await createExpressServer(config, graphQLSchema, createContext, true, '', false);
       return { keystone, context: createContext().sudo(), app };
     }
@@ Expand Down @@