Added session max age cookie to match keystone.uid cookie expiry #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @millsy! I cherrypicked and merged your first commit after testing. Updates to dependencies should be done separately, so I skipped the Mongoose bump. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add the session max age cookie (defaults to name this.sid) to match the expiry of the keystone.uid cookie. This correctly then expires when the keystone.uid cookie expires forcing the user to need to re-authenticate.
Related issues (if any)
As described in Issue #4494
Testing
npm test run-all doesn't work - fails on npm test && npm run test-e2e-bg but this occurred before the change was made, so it's likely my env causing build issues.