-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes scroll for modals in the Admin UI #4169
Conversation
Please merge this at the earliest |
Fix the lint error
@keystonejs/leads please merge as minor. |
Thanks for the fix - it will be included in the next release. If anyone would mind updated related issues, that would be greatly appreciated. |
Can I get this via npm? I have a continuous deployment running with 4.0.0-beta.8 so any changes via my project's git get overwritten. |
Include this to next release please. |
@1337cookie @kamontat This change has been committed to master and will be included in the next 4.0.0 release. It is not included in See the 4.0.0 Milestone for issues currently being triaged for release. Please us on the Keystone Slack in #keystone-4-release if you'd like to discuss or flag any blocking/critical issues for a 4.0.0 release. Regards, |
FYI, a fix for this issue is included in Keystone Regards, |
Description of changes
Fixes the scroll problem with modals in the Admin UI, when the height of the modal form is higher than the one of the screen.
Related issues (if any)
#3712, #3822 and #4025
fixes #3822
fixes #4025
Testing
Create a new item for a List with many fields, if the modal form is higher than the visible screen then that modal must be scrollable and the "Create" button visible.
npm run test-all
ran successfully.