Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scroll for modals in the Admin UI #4169

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Fixes scroll for modals in the Admin UI #4169

merged 2 commits into from
Apr 10, 2018

Conversation

saul-mtz
Copy link
Contributor

@saul-mtz saul-mtz commented Apr 1, 2017

Description of changes

Fixes the scroll problem with modals in the Admin UI, when the height of the modal form is higher than the one of the screen.

Related issues (if any)

#3712, #3822 and #4025

fixes #3822
fixes #4025

Testing

Create a new item for a List with many fields, if the modal form is higher than the visible screen then that modal must be scrollable and the "Create" button visible.

  • Please confirm npm run test-all ran successfully.

Fixes the scroll problem, related with issues #3712, #3822 and #4025
@VinayaSathyanarayana
Copy link

Please merge this at the earliest

Fix the lint error
@morenoh149
Copy link
Contributor

@keystonejs/leads please merge as minor.

@JedWatson JedWatson merged commit a2e0aff into keystonejs:master Apr 10, 2018
@JedWatson
Copy link
Member

Thanks for the fix - it will be included in the next release. If anyone would mind updated related issues, that would be greatly appreciated.

gautamsi referenced this pull request in gautamsi/keystone-ts May 15, 2018
@1337cookie
Copy link
Contributor

Can I get this via npm? I have a continuous deployment running with 4.0.0-beta.8 so any changes via my project's git get overwritten.

@kamontat
Copy link

Include this to next release please.

@stennie stennie added the bug label Jun 20, 2018
@stennie stennie added this to the 4.0.0 milestone Jun 20, 2018
@stennie
Copy link
Contributor

stennie commented Jun 20, 2018

@1337cookie @kamontat This change has been committed to master and will be included in the next 4.0.0 release. It is not included in 4.0.0-beta.8, which is currently the latest beta published on npm.

See the 4.0.0 Milestone for issues currently being triaged for release.

Please us on the Keystone Slack in #keystone-4-release if you'd like to discuss or flag any blocking/critical issues for a 4.0.0 release.

Regards,
Stennie

@stennie
Copy link
Contributor

stennie commented Jun 22, 2018

FYI, a fix for this issue is included in Keystone 4.0.0-rc.0 which is now available via npm. Release notes: https://github.com/keystonejs/keystone/releases/tag/v4.0.0-rc.0.

Regards,
Stennie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants