Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use const in strict-mode in Boom dependency #4439

Closed
vitalbone opened this issue Sep 21, 2017 · 2 comments
Closed

Can't use const in strict-mode in Boom dependency #4439

vitalbone opened this issue Sep 21, 2017 · 2 comments

Comments

@vitalbone
Copy link
Contributor

Discovered this bug in the Travis build of this PR: keystonejs/keystone#4157

Expected behavior

Should not throw.

Actual/Current behavior

Throws when trying to require Hoek.

Steps to reproduce the actual/current behavior

  • nvm use 0.10.x
  • npm i
  • It will break here and you should see this error:

screen shot 2017-09-22 at 9 07 29 am

Potential fix

We could place our node 0.10.x - 0.12.x CI build behind a harmony flag? As suggested in this StackOverflow - https://stackoverflow.com/questions/22603078/syntaxerror-use-of-const-in-strict-mode

Environment

Software Version
Keystone 4.0.0-beta.5
Node 0.10.48
@laurenskling
Copy link
Contributor

Node 0.10 doesn't know what const is. Upgrade your Node version.

@vitalbone
Copy link
Contributor Author

Thanks @laurenskling, yes [email protected] doesn't know what const is. That is kind of different to this issue though since the actual problem is more to do with keystone's ongoing support for [email protected] (as per the Travis builds). Fortunately there has been discussion around moving away from catering for < [email protected] over here keystonejs/keystone#4453 so am going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants