Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inability gunzipping compressed log files #78

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Fix inability gunzipping compressed log files #78

merged 1 commit into from
Nov 29, 2017

Conversation

nitrocode
Copy link
Contributor

Fixed #75

From nodejs/node#2485 (comment) it's better to use writeStream's finish event instead of readStream's end event.

@vmarchaud
Copy link
Contributor

Sorry we are a little busy this week, i will take the time to merge your PRs next week !

@nitrocode
Copy link
Contributor Author

Thank you! Let me know if there are any additional changes that need to be made.

@nitrocode
Copy link
Contributor Author

@vmarchaud any update?

@vmarchaud vmarchaud merged commit 0414689 into keymetrics:master Nov 29, 2017
@nitrocode
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @vmarchaud