Package improves - drop unused package and some package.json improves#304
Open
kravetsone wants to merge 2 commits intokeymetrics:masterfrom
Open
Package improves - drop unused package and some package.json improves#304kravetsone wants to merge 2 commits intokeymetrics:masterfrom
package.json improves#304kravetsone wants to merge 2 commits intokeymetrics:masterfrom
Conversation
… set `type` to `commonjs`
|
Code Climate has analyzed commit af18351 and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the
asyncpackage is not used in the code, but users are forced to download it.I also used the
filesfield to prevent unnecessary files from being added to the npm package.And I also deleted the
modulefield since it is not actually supplied (config/exports/tsconfig.module.jsonfrombuild:modulealso does not exist)