-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bixby/Menu and Search button support with screen off #955
Comments
Hi, yeah it can be! The screen-off detection is very janky though and only works if you are rooted. No guarantee that it will work well on your device. |
Mine's rooted, so I'm not deterred =) I can test a build if you're willing to provide one. |
My S9+ is rooted as well. Thanks so much for adding the Bixby button to this list. (No rush at all! I'll make do for now.) I'll also be happy to test a build, if you'd like. |
This thread seems to be the most relevant for me to ask - what about supporting the Google Assistant button when the screen is off? KeyMapper labels it as |
@t184256 @BluestarZero can you please try this apk :) keymapper-2.5.0-alpha-debug.zip |
I'll add this as well! |
@iFUCKINGHATEcomputers can you try this apk for the search button :) keymapper-2.5.0-alpha-debug.zip |
Thanks for this alpha build, but i couldn't get the Bixby (Menu) button to work properly. Mappings seem to work fine when the screen is on, but not at all whenthe screen is off and phone is locked, even when I added in the "Screen is off" constraint and checked the "Detect when screen is off" checkbox. I wonder if @t184256 is having the same issue. |
Didn't work, sadly. Volume down works fine with screen off, Menu button with same conf doesn't, nothing observed in the logs related to me pressing it. |
Okay, can you two run the |
Here's what my output looks like: star2lte:/ $ getevent |
@BluestarZero sorry, can you do |
No problem. This looks more understandable: star2lte:/ $ getevent -lq |
try this :) keymapper-2.5.0-alpha-debug.zip |
MAN, you work fast. I'll give this one a try! |
Haha, this issue is just changing one line 😄 |
On the go, but that one seems to work in general with just a ~second window of not working immediately after I lock the screen. |
Yeah, this is an issue with this method. It is super janky. I'm not sure what I can do to improve it. I would have to make an Xposed module to be able to do this properly. |
Well, it's infinitely more useful than a button that just does nothing when I operate my device from the pocket, so I'm happy. |
Cool, I'll merge this request then |
implemented |
You did it! It seems to work now! Although, sometimes, I have to press the button when once before the map actually works. But for now, it's working properly. I'll have to daily drive for a while to get a better feel of my maps. Thank you so much! |
Ayy, the |
My device (Samsung S10e) has that Bixby button, detectable as
Menu
. Could it be supported for remapping with the screen off?Developer TODO (don't remove)
The text was updated successfully, but these errors were encountered: